Make #have_relationships accept symbols #15
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
lancedikson
force-pushed
the
fix/have_relationships_symbols
branch
from
16cbbf7 to
c713856
Compare
|
For some reason, Github Actions weren't triggered, but the tests are passing on my laptop :) Would you mind running Actions manually? |
|
@lancedikson I'm reluctant to merging this. We should either update all the helpers to allow symbols or keep things the way these are now. If you're willing to provide support for all the marchers, I'll be happy to merge it. |
Closed
3 tasks
|
Superseded by #18 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What is the current behavior?
I noticed that the
have_relationshipsbehavior mentioned in README.md doesn't work with a parsed JSON object if I pass symbols as described in the docs:expect(document['data']).to have_relationships(:posts, :comments)What is the new behavior?
Now,
have_relationshipsworks both with symbols and strings.Checklist
Please make sure the following requirements are complete:
features)