Fix TS definitions #633
Merged
Fix TS definitions #633
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
- Converted lhs into an array of ExprNode (optional with empty array)
mattbaileyuk
approved these changes
Apr 17, 2023
|
Thanks for fixing this! 👍 |
nddery
added a commit
to Stedi/jsonata
that referenced
this pull request
Mar 6, 2024
An update to the TS definition in jsonata-js#633 is causing issues in transformers-jsonata since we are using both 1.x and 2.x versions in there and types do not align anymore. Reverting the change for now. We overwrite the type of the NodeExpr in mappings anyway, and so this should be fine for now.
nddery
added a commit
to Stedi/jsonata
that referenced
this pull request
Mar 6, 2024
is causing issues in transformers-jsonata since we are using both 1.x and 2.x versions in there and types do not align anymore. Reverting the change for now. We overwrite the type of the NodeExpr in mappings anyway, and so this should be fine for now.
nddery
added a commit
to Stedi/jsonata
that referenced
this pull request
Mar 6, 2024
An update to the TS definition in jsonata-js#633 is causing issues in transformers-jsonata since we are using both 1.x and 2.x versions in there and types do not align anymore. Reverting the change for now. We overwrite the type of the NodeExpr in mappings anyway, and so this should be fine for now.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Signed-off-by: Dishant Kaushik dkaushik95@gmail.com
Related issue: #585