Fix crash when calling .destroy() on a BrowserWindow #197
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
+1 |
jsonnull
force-pushed
the
fix-cleanup-subscriptions
branch
from
7cf07e2 to
6bf4183
Compare
Merged
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes a crash that happens when calling
.destroy()on a BrowserWindow with an electron-trpc handler attached.detachHandlercan potentially be called with a destroyed window, which then causes a crash on accessingwin.webContents.id. See #156 for a reproduction case.Definitely open to alternate solutions here! Feel free to close this PR or push to the branch directly if you'd like any changes.
Closes #156