Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix infinite recursion on some schemas when setting defaults (#359) #365

Merged
merged 14 commits into from
Mar 21, 2017
Merged

Fix infinite recursion on some schemas when setting defaults (#359) #365

merged 14 commits into from
Mar 21, 2017

Commits on Mar 17, 2017

  1. Don't try to fetch files that don't exist 

    Throws an exception when the ref can't be resolved to a useful file URI,
rather than waiting for something further down the line to fail after
the fact.
    @erayd
    erayd committed Mar 17, 2017
    Configuration menu
    Copy the full SHA
    93c5a64 View commit details
    Browse the repository at this point in the history

  2. Refactor defaults code to use LooseTypeCheck where appropriate

    @erayd
    erayd committed Mar 17, 2017
    Configuration menu
    Copy the full SHA
    976cfb0 View commit details
    Browse the repository at this point in the history

  3. Test for not treating non-containers like arrays

    @erayd
    erayd committed Mar 17, 2017
    Configuration menu
    Copy the full SHA
    bdf8d06 View commit details
    Browse the repository at this point in the history

  4. Update comments

    @erayd
    erayd committed Mar 17, 2017
    Configuration menu
    Copy the full SHA
    8ecbca2 View commit details
    Browse the repository at this point in the history

  5. Rename variable for clarity

    @erayd
    erayd committed Mar 17, 2017
    Configuration menu
    Copy the full SHA
    7b869c0 View commit details
    Browse the repository at this point in the history

  6. Add CHECK_MODE_ONLY_REQUIRED_DEFAULTS 

    If CHECK_MODE_ONLY_REQUIRED_DEFAULTS is set, then only apply defaults
if they are marked as required.
    @erayd
    erayd committed Mar 17, 2017
    Configuration menu
    Copy the full SHA
    4ed0591 View commit details
    Browse the repository at this point in the history

  7. Workaround for $this scope issue on PHP-5.3

    @erayd
    erayd committed Mar 17, 2017
    Configuration menu
    Copy the full SHA
    35c03bb View commit details
    Browse the repository at this point in the history

  8. Fix infinite recursion via $ref when applying defaults

    @erayd
    erayd committed Mar 17, 2017
    Configuration menu
    Copy the full SHA
    50c26d0 View commit details
    Browse the repository at this point in the history

  9. Add missing second test for array case

    @erayd
    erayd committed Mar 17, 2017
    Configuration menu
    Copy the full SHA
    852ad07 View commit details
    Browse the repository at this point in the history

  10. Add test for setting a default value for null

    @erayd
    erayd committed Mar 17, 2017
    Configuration menu
    Copy the full SHA
    37aa991 View commit details
    Browse the repository at this point in the history

  11. Also fix infinite recursion via $ref for array defaults

    @erayd
    erayd committed Mar 17, 2017
    Configuration menu
    Copy the full SHA
    e0baac8 View commit details
    Browse the repository at this point in the history

  12. Move nested closure into separate method

    @erayd
    erayd committed Mar 17, 2017
    Configuration menu
    Copy the full SHA
    e098ee7 View commit details
    Browse the repository at this point in the history

  13. $parentSchema will always be set when $name is, so don't check it

    @erayd
    erayd committed Mar 17, 2017
    Configuration menu
    Copy the full SHA
    c4031e1 View commit details
    Browse the repository at this point in the history

  14. Handle nulls properly - fixes issue jsonrainbow#377

    @erayd
    erayd committed Mar 17, 2017
    Configuration menu
    Copy the full SHA
    f63d938 View commit details
    Browse the repository at this point in the history