Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Backports for 5.2.1 #413

Merged
merged 7 commits into from
May 16, 2017
Merged

Backports for 5.2.1 #413

merged 7 commits into from
May 16, 2017

Conversation

erayd
Copy link
Contributor

@erayd erayd commented Apr 11, 2017 •
edited
Loading

Bugfixes from 6.0.0 that can be backported to 5.2.1 without breaking backwards-compatibility.

Backported PRs

Skipped PRs

erayd and others added 3 commits April 12, 2017 08:57
@erayd
Split $objectDefinition into $schema and $properties (jsonrainbow#411)
f32aaf1 
Object validation attempts to use a single variable to store both the
object definition, and its properties. This causes validation to be
incomplete where "properties" is not set, but "additionalProperties" is.

This commit fixes both bugs in issue jsonrainbow#353.
@HunterEl @erayd
Issue-414: Allow The Option of T or space for Date time. (jsonrainbow…
f375f0b 
…#415)
@flolivaud @erayd
Testcase for minProperties with properties defined (jsonrainbow#416)
9a37ca4 
+ Fix Test
This was referenced May 3, 2017
Closed
Closed
bighappyface
bighappyface approved these changes May 5, 2017
View reviewed changes
Copy link
Collaborator

@bighappyface bighappyface left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

+1

erayd and others added 3 commits May 6, 2017 09:21
@erayd
[BUGFIX] Cast empty schema arrays to object (jsonrainbow#409)
a9722e6 
* Cast root to object

* Use function_exists to allow polyfill compatibility

* Move array->object conversion to SchemaConstraint & SchemaStorage

Fixes issue jsonrainbow#408
@mathroc @erayd
fix bug when applying defaults for array items when the schema is for (…
e231775 
…jsonrainbow#405)

all items and add support for minItems when applying defaults
@erayd
[BUGFIX] Split "uri" format into "uri" & "uri-reference", fix meta-sc…
bd40dbb 
…hema bug (jsonrainbow#419)

* Split "uri" format into "uri" and "uri-reference"

* Correct format for id & $ref in draft-03/04 meta-schemas

See json-schema-org/JSON-Schema-Test-Suite#177 (comment)
@erayd
Copy link
Contributor Author

erayd commented May 16, 2017

@bighappyface Anything else you want in 5.2.1? I reckon this is about ready to ship.

@bighappyface
Copy link
Collaborator

This works for me. I will merge and roll 5.2.1.

@bighappyface bighappyface merged commit 429be23 into jsonrainbow:5.x.x May 16, 2017
@erayd
Copy link
Contributor Author

erayd commented May 16, 2017

Awesome - thanks :-).

@erayd erayd deleted the backport-521 branch May 16, 2017 21:08
@bighappyface
Copy link
Collaborator

We are ready to go: https://github.com/justinrainbow/json-schema/releases/tag/5.2.1

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@bighappyface bighappyface bighappyface approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
5 participants
@erayd @bighappyface @HunterEl @flolivaud @mathroc