Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Backports for 5.2.2 (Part 1) #431

Merged
merged 2 commits into from
Jun 5, 2017
Merged

Conversation

erayd
Copy link
Contributor

@erayd erayd commented Jun 5, 2017

Bugfixes from 6.0.0 that can be backported to 5.2.2 without breaking backwards-compatibility.

Backported PRs

Skipped PRs

There are no skipped PRs.

erayd added 2 commits June 6, 2017 07:52
…nbow#429)

* Remove dev-time dependency on phpdocumentor due to resolution headaches

* Switch distro for hhvm testing to trusty (precise now unsupported)
Note that this bugfix will cause empty query strings to be dropped (e.g.
http://example.com?#blue becomes http://example.com#blue). This is
because the '?' character is deliberately not captured as part of the
query string, and the testsuite expects to be able to pass an empty
query string and *not* have the '?' added for that case.
Copy link
Collaborator

@bighappyface bighappyface left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

+1

@bighappyface bighappyface merged commit 2a42039 into jsonrainbow:5.x.x Jun 5, 2017
@erayd erayd deleted the backport-522 branch June 5, 2017 20:47
@erayd erayd changed the title Backports for 5.2.2 Backports for 5.2.2 (Part 1) Jun 6, 2017
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants