Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Backports for 5.2.2 (Part 3) #450

Merged
merged 2 commits into from
Oct 3, 2017
Merged

Backports for 5.2.2 (Part 3) #450

merged 2 commits into from
Oct 3, 2017

Commits on Oct 3, 2017

  1. Update php-csfixer rules to address problem in 2.7 & new multiline ru… 

    …le (jsonrainbow#449)

* Update php-csfixer rules to address problem in 2.7 & new multiline rule

 * yoda_style in 2.7 is dangerous and may result in logic errors. In
 some cases, it also results in invalid syntax.

 * multiline comments prefixed with // now seem to be misaligned, and
 this cannot be disabled, so have changed the relevant comment.

* PHP-5.3 is not available on trusty, so explicitly specify precise for 5.3
    @erayd
    erayd committed Oct 3, 2017
    Configuration menu
    Copy the full SHA
    1a330df View commit details
    Browse the repository at this point in the history

  2. Add proper recursive handling for $ref resolution base (jsonrainbow#448) 

    Fixes jsonrainbow#447

Note that this patch does not check whether a given container is
actually a schema when recursing into it. In most cases this will
not matter, however it does mean that in some edge cases it will
attempt to resolve a `$ref` in a context where ref is actually not
part of the spec. Limiting resolution to schema-context containers
is outside the scope of this patch, but can be added later.
    @erayd
    erayd committed Oct 3, 2017
    Configuration menu
    Copy the full SHA
    a2cfa75 View commit details
    Browse the repository at this point in the history