marc-mabe/php-enum versions #464
Conversation
There was a problem hiding this comment.
Looks good to me - thanks :-).
@bighappyface - The Travis fail can be ignored; it's just php-cs-fixer introducing some new logic and breaking the syntax test. Again :-(. I will open a separate PR to deal with that when I have some time, but the problem was not triggered by this PR.
|
Is the intent to make |
|
(Asking this because it's related to #569.) |
|
@wimleers Looks like we sort of forgot to follow up on this one. We only use the most basic, vanilla features of php-enum. I had a quick look at the "BC break" tags listed in the 3.0 release, and I didn't see anything that would impact us. On the other hand, with 3.0 he raises the minimal required PHP version to 5.6, and we're still on 5.3. So, we can't fully switch to 3.0 without creating PHP dependency issues, and if we stay on 2.0 then we don't always get the latest and greatest. Any suggestions? |
marc-mabe
force-pushed
the
enum_versions
branch
from
48406b0
to
a55b694
Compare
|
PR is rebased now
yes |
|
any update on this ? |
|
@erayd I'm not really familiar with the version branch strategy. Which one do we target with this? |
|
@shmax |
@shmax - exactly what @marc-mabe said above. That constraint should be fine for what we are doing, so long as you're happy that the syntax is the same for the bits you use - I'm assuming that because you approved the PR, that is the case. |
|
I was talking more about master vs one of our version branches (eg. 5.x.x, 6.0.dev). Master it is, then. |
|
@shmax Always master. Merging PRs directly into 5.x.x causes problems. This one will probably make it into my next backport release though. |
## Backported PRs * #559 ArraysTest for array items with enum validation * #567 Don't run checks which assume a defined instance against undefined * #575 Tests on PHP 7.3 * #587 Fixed PHPDoc of Validator::validate() method * #583 Fix travis PHP 5.4 and 5.5 config ## Additional PRs (5.x.x only) These PRs are only applicable to the 5.x.x branch, and have been merged individually. * #589 Update validate-json to use spl_autoload_register ## Skipped PRs * #464 marc-mabe/php-enum versions (dependency not present in 5.x.x)
I'm very happy you are planning to use my small library :)
As you are using base functionality only you can support much more versions of it. This helps a lot in cases you have to deal with more libraries and all have different dependent versions.