Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix: Disable no_superfluous_phpdoc_tags fixer #599

Conversation

localheinz
Copy link
Contributor

This PR

  • disables the no_superfluous_phpdoc_tags fixer, which is implicitly enabled by using the @Symfony rules

Related to #598.

💁‍♂ Personally, I would not use the @Symfony ruleset, but instead configure fixers one by one. I do this with localheinz/php-cs-fixer-config, which allows me to re-use a configuration for friendsofphp/php-cs-fixer across projects. Together with https://dependabot.com, this works excellent, by the way, in keeping projects updated with a consistent configuration.

@erayd
Copy link
Contributor

erayd commented Nov 13, 2019

Thanks for this, and for your other PR. I don't have an opinion one way or the other on the @Symfony ruleset - would you like to continue with exceptions from it, or would you rather change to the approach you've outlined above? I'm quite happy with either.

My main consideration is that it doesn't do unexpected things to the source without warning; provided that criteria is met, then the configuration can be whatever people prefer.

@localheinz
Copy link
Contributor Author

@erayd

Perhaps #600 is even more critical?

I'd be happy to help sorting out the fixer configuration!

@localheinz localheinz closed this Jan 24, 2021
@localheinz localheinz deleted the fix/no-superfluous-phpdoc-tags branch January 24, 2021 17:24
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants