Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Streamline validation of Regex #650

Merged
merged 1 commit into from
Jan 8, 2021
Merged

Streamline validation of Regex #650

merged 1 commit into from
Jan 8, 2021

Conversation

a-r-m-i-n
Copy link
Contributor

And always escape used delimiter in passed pattern.

Resolves: #649

@a-r-m-i-n
Streamline validation of Regex
2baceb3 
And always escape used delimiter in passed pattern.

Resolves: #649
erayd
erayd approved these changes Jan 8, 2021
View reviewed changes
Copy link
Contributor

@erayd erayd left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks 😁.

@erayd erayd merged commit f4f0c34 into jsonrainbow:master Jan 8, 2021
@guilliamxavier
Copy link
Contributor

I just got hit by that. Could this bugfix be backported to 5.x.x and released as 5.2.11? 😄 Thanks in advance

@guilliamxavier
Copy link
Contributor

Wait, there's another place. I'm preparing a PR

@guilliamxavier guilliamxavier mentioned this pull request Feb 4, 2021
Merged
@guilliamxavier
Copy link
Contributor

See #653

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@ohader ohader ohader requested changes

@erayd erayd erayd approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Bug: Unescaped slash throws error, when pattern contains slash
4 participants
@a-r-m-i-n @guilliamxavier @erayd @ohader