-
Notifications
You must be signed in to change notification settings - Fork 354
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fix(UndefinedConstraint): add attribute #[AllowDynamicProperties]
#695
fix(UndefinedConstraint): add attribute #[AllowDynamicProperties]
#695
Conversation
…o allow applying defaults without deprecation warning
@erayd May we please get this merged so we don't see the deprecation warning on PHP 8.2? |
Thank you! |
Hi @erayd, sorry to bother you again, but would it be possible to get a release for this fix? I made the release description below to make it easier for you. Thanks. Release: v5.2.13
|
@Seldaek Hi, sorry to bother you, but would it be possible to create a release that contains this fix? (Asking because I noticed you made the latest two releases) |
@taka-oyama This is actually waiting for a backport release. You've put this PR on the master branch, which is where it's supposed to go (thank you 🙂), but note that the master branch is the v6 track, which doesn't have a release yet. I'm desperately short on time, but hoping to find a moment to do this over the weekend. If @Seldaek beats me to it [please do if you have the time!], he's welcome to, but I'm aware he is also quite busy. Once backported to 5.x.x, we can roll a release for it. |
Thank you for letting me know! Very grateful for the response 🙏🏻 |
@erayd sorry but I'll have to pass :) |
… without deprecation warning (jsonrainbow#695)
I created a backport pull request #695 for your convenience. |
Thanks @taka-oyama 🙂. Merged & released as v5.2.13. |
This change will workaround deprecation warning while applying defaults with php8.2
php8.2 deprecations
example code
This change is safe for all php versions >=5.3.0 - online check with 3v4l.org