Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Addresses Content-Type mismatch on HTTP 301 Moved Permanently with FileGetContents #709

Merged
merged 4 commits into from
May 27, 2024
Merged

Addresses Content-Type mismatch on HTTP 301 Moved Permanently with FileGetContents #709

merged 4 commits into from
May 27, 2024

Commits on May 26, 2024

  1. test: Add test failure

    @DannyvdSluijs
    DannyvdSluijs committed May 26, 2024
    Configuration menu
    Copy the full SHA
    b7475c0 View commit details
    Browse the repository at this point in the history

  2. test: Remove file_get_contents override and incorrect/invaluable tests 

    Overriding file_get_contents introduces different behaviour from the native function, such as the $http_response_headers missing. Removing the override revealed two test (testing a specific return path of the file_get_contents method rather then testing the behaviour or result of the subject under test) which had different behaviour between the test and runtime, therefor these tests have been removed.
    @DannyvdSluijs
    DannyvdSluijs committed May 26, 2024
    Configuration menu
    Copy the full SHA
    e6ea522 View commit details
    Browse the repository at this point in the history

  3. fix: Parse headers in reverse order to match with last header avoidin… 

    …g matches on HTTP 301 redirect headers which are listed first
    @DannyvdSluijs
    DannyvdSluijs committed May 26, 2024
    Configuration menu
    Copy the full SHA
    4479f6e View commit details
    Browse the repository at this point in the history

  4. style: Correct code style violations

    @DannyvdSluijs
    DannyvdSluijs committed May 26, 2024
    Configuration menu
    Copy the full SHA
    4f0e8f2 View commit details
    Browse the repository at this point in the history