Remove obsolete check if FILTER_FLAG_EMAIL_UNICODE is defined #772
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
There was a problem hiding this comment.
Nice cleanup @W0rma!
Two things that is needed before this can be merged.
- The pipeline is providing some feedback about an ignored error in PHPStan. Could you remove it from the
phpstan-baseline.neonwhich can be done by running./vendor/bin/phpstan --generate-baseline - Could you add an entry i the
CHANGELOG.md(link)[https://github.com/jsonrainbow/json-schema/blob/master/CHANGELOG.md] under changed?
|
@DannyvdSluijs Thank you for the review - Done! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
FILTER_FLAG_EMAIL_UNICODEis available in PHP 7.1 or higher https://www.php.net/manual/en/filter.constants.php#constant.filter-flag-email-unicode and this package does no longer support PHP 7.1 or lower.Therefore the check can be safely removed.