Correct PHPStan findings in validator #808
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
W0rma
reviewed
Mar 19, 2025
DannyvdSluijs
force-pushed
the
correct-phpstan-findings-in-validator
branch
from
eac9e23 to
9ffc75e
Compare
DannyvdSluijs
force-pushed
the
correct-phpstan-findings-in-validator
branch
from
9ffc75e to
e8124cd
Compare
DannyvdSluijs
added a commit
that referenced
this pull request
Mar 25, 2025
This pull request includes several changes to the `JsonSchema` library, focusing on adding type hints and improving code documentation. The most important changes include removing certain entries from `phpstan-baseline.neon`, adding type hints to methods in `Validator.php`, and updating deprecation notices. Improvements to type hints and code documentation: * [`src/JsonSchema/Validator.php`](diffhunk://#diff-41de454e04e08a0284513e682c94d3f01f9c4a2a6b2faa51b5868bdd0826e42eL44-R48): Added type hints to the `validate`, `check`, and `coerce` methods, specifying the return type as `int` and including detailed parameter documentation. [[1]](diffhunk://#diff-41de454e04e08a0284513e682c94d3f01f9c4a2a6b2faa51b5868bdd0826e42eL44-R48) [[2]](diffhunk://#diff-41de454e04e08a0284513e682c94d3f01f9c4a2a6b2faa51b5868bdd0826e42eL85-R104) Updates to `phpstan-baseline.neon`: * [`phpstan-baseline.neon`](diffhunk://#diff-995edee38ad4f8387e58ebd52c31bcc04c56cc2448d331b1cf5e0b35c57b9efaL903-L932): Removed multiple entries related to the `JsonSchema\Validator` class, which were previously indicating missing type hints. These entries are no longer needed due to the added type hints in the code.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This pull request includes several changes to the
JsonSchemalibrary, focusing on adding type hints and improving code documentation. The most important changes include removing certain entries fromphpstan-baseline.neon, adding type hints to methods inValidator.php, and updating deprecation notices.Improvements to type hints and code documentation:
src/JsonSchema/Validator.php: Added type hints to thevalidate,check, andcoercemethods, specifying the return type asintand including detailed parameter documentation. [1] [2]Updates to
phpstan-baseline.neon:phpstan-baseline.neon: Removed multiple entries related to theJsonSchema\Validatorclass, which were previously indicating missing type hints. These entries are no longer needed due to the added type hints in the code.