Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: render username even if no url specified #21

Merged
merged 1 commit into from
Jul 24, 2022
Merged

fix: render username even if no url specified #21

merged 1 commit into from
Jul 24, 2022

Conversation

SethFalco
Copy link
Member

When given a JSON Resume with the following, the theme would render an unappealing entry for that profile. This will allow use that username as-is without being linked.

{
  "profiles": [
    {
      "network": "Twitter",
      "username": "neutralthoughts",
      "url": ""
    },
    {
      "network": "SoundCloud",
      "username": "dandymusicnl",
      "url": "https://soundcloud.com/dandymusicnl"
    }
  ]
}

Before

image

After

image

@SethFalco SethFalco merged commit 77120d1 into jsonresume:main Jul 24, 2022
@SethFalco SethFalco deleted the fix/profile-no-url branch July 24, 2022 16:00
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant