Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Schema corrections by @madskristensen without tabs/spaces #107

Merged
merged 3 commits into from
Jul 15, 2014
Merged

Schema corrections by @madskristensen without tabs/spaces #107

merged 3 commits into from
Jul 15, 2014

Conversation

ocram
Copy link
Contributor

@ocram ocram commented Jul 14, 2014

Fixes the same issues that @madskristensen fixed in #105

But without:

  • indentation changes (tabs/spaces)
  • changes to email section which have become obsolete
  • changes to profiles section which did neither match the current use in resume.json nor the style from email

Renaming necessary for tests to pass. Property name `awardDate` was in the `schema.json` but all the examples (`resume.json`, `thomasdavis.json` and `rolandsharp.json`) actually had `date` only.
@ocram ocram mentioned this pull request Jul 14, 2014
@madskristensen
Copy link

Please keep in mind that by not changing email and profile, the thomasdavis.json example on jsonresume.org is not valid.

@ocram
Copy link
Contributor Author

ocram commented Jul 14, 2014

The example on jsonresume.org is just outdated. The homepage is not updated as often as this repository. The only file that must be valid in any case is resume.json, because it is validated against the schema in the tests.

@DonDebonair
Copy link
Member

+1 for merging this!

@thomasdavis
Copy link
Member

Okay, I will merge this soon, have to do write up the Changelog for it. We didn't really get a consensus vote for awardDate -> date but it makes sense and we will just go with it.

thomasdavis added a commit that referenced this pull request Jul 15, 2014
@thomasdavis thomasdavis merged commit a236a3c into jsonresume:master Jul 15, 2014
@thomasdavis
Copy link
Member

@madskristensen Thanks again, we are doing a quick release of a 0.0.0 version, once that is in place, everything will be updated. Then all modules will follow the versioning system and update accordingly.

@thomasdavis
Copy link
Member

I will also do a write up once this is done, and clone the schemastore.org to make sure everything is in sync.

@madskristensen
Copy link

Sounds good. Let me know if I can help

@thomasdavis
Copy link
Member

Schema is looking much healthier now. The last question is, I wonder if we
should enforce additionalProperties: false. I don't really have any qualms
with developers extending their resumes as long as they understand the
consequences.

On Tue, Jul 15, 2014 at 2:39 PM, Mads Kristensen notifications@github.com
wrote:

Sounds good. Let me know if I can help


Reply to this email directly or view it on GitHub
#107 (comment)
.

Thomas Davis
http://thomasdav.is

VP of Tech - Earbits - http://earbits.com
Co-founder - Cdnjs - http://cdnjs.com
Founder - Backbone Tutorials - http://backbonetutorials.com

@thomasdavis
Copy link
Member

Also added an issue to document that are now available on SchemaStore.org

#108

On Tue, Jul 15, 2014 at 2:41 PM, Thomas Davis thomasalwyndavis@gmail.com
wrote:

Schema is looking much healthier now. The last question is, I wonder if we
should enforce additionalProperties: false. I don't really have any qualms
with developers extending their resumes as long as they understand the
consequences.

On Tue, Jul 15, 2014 at 2:39 PM, Mads Kristensen <notifications@github.com

wrote:

Sounds good. Let me know if I can help


Reply to this email directly or view it on GitHub
#107 (comment)
.

Thomas Davis
http://thomasdav.is

VP of Tech - Earbits - http://earbits.com
Co-founder - Cdnjs - http://cdnjs.com
Founder - Backbone Tutorials - http://backbonetutorials.com

Thomas Davis
http://thomasdav.is

VP of Tech - Earbits - http://earbits.com
Co-founder - Cdnjs - http://cdnjs.com
Founder - Backbone Tutorials - http://backbonetutorials.com

@madskristensen
Copy link

If additionalProperties are not set to false, then validation will be tough, because almost any JSON file will validate against the schema

@ocram ocram deleted the schema-flaws-madskristensen branch July 15, 2014 04:44
@ocram
Copy link
Contributor Author

ocram commented Jul 15, 2014

... and the tools/themes will generally not make use of any additional properties. Apart from that, the more permissive the specification is, the less powerful and successful will the standard be (due to fragmentation, confusion, etc.), right?

@thomasdavis
Copy link
Member

Yep, the tests should be strict for tools that are trying to adhere to the
standard. If people are willing to deviate they will have to deal with
broken test for now.

On Tue, Jul 15, 2014 at 2:46 PM, Marco notifications@github.com wrote:

... and the tools/themes will generally not make use of any additional
properties. Apart from that, the more permissive the specification is, the
less powerful and successful will the standard be (due to fragmentation,
confusion, etc.), right?


Reply to this email directly or view it on GitHub
#107 (comment)
.

Thomas Davis
http://thomasdav.is

VP of Tech - Earbits - http://earbits.com
Co-founder - Cdnjs - http://cdnjs.com
Founder - Backbone Tutorials - http://backbonetutorials.com

@madskristensen
Copy link

You probably also want to set "required": ["bio"] so empty documents won't validate either. That's the case now as you can see here http://schemastore.org/validator/#/schemas/json/resume

@thomasdavis
Copy link
Member

Good idea, and also, awesome link! We were using our CLI tool for test but
the GUI makes it pretty easy to set errors.

On Tue, Jul 15, 2014 at 2:54 PM, Mads Kristensen notifications@github.com
wrote:

You probably also want to set "required": ["bio"] so empty documents
won't validate either. That's the case now as you can see here
http://schemastore.org/validator/#/schemas/json/resume


Reply to this email directly or view it on GitHub
#107 (comment)
.

Thomas Davis
http://thomasdav.is

VP of Tech - Earbits - http://earbits.com
Co-founder - Cdnjs - http://cdnjs.com
Founder - Backbone Tutorials - http://backbonetutorials.com

@madskristensen
Copy link

I'm glad you like it. I've just published it a few minutes ago. Still a work in progress. Let me know if you have any ideas for improvements

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants