-
Notifications
You must be signed in to change notification settings - Fork 278
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Schema corrections by @madskristensen without tabs/spaces #107
Schema corrections by @madskristensen without tabs/spaces #107
Conversation
Renaming necessary for tests to pass. Property name `awardDate` was in the `schema.json` but all the examples (`resume.json`, `thomasdavis.json` and `rolandsharp.json`) actually had `date` only.
Please keep in mind that by not changing |
The example on jsonresume.org is just outdated. The homepage is not updated as often as this repository. The only file that must be valid in any case is |
+1 for merging this! |
Okay, I will merge this soon, have to do write up the Changelog for it. We didn't really get a consensus vote for awardDate -> date but it makes sense and we will just go with it. |
Schema corrections by @madskristensen without tabs/spaces
@madskristensen Thanks again, we are doing a quick release of a 0.0.0 version, once that is in place, everything will be updated. Then all modules will follow the versioning system and update accordingly. |
I will also do a write up once this is done, and clone the schemastore.org to make sure everything is in sync. |
Sounds good. Let me know if I can help |
Schema is looking much healthier now. The last question is, I wonder if we On Tue, Jul 15, 2014 at 2:39 PM, Mads Kristensen notifications@github.com
Thomas Davis VP of Tech - Earbits - http://earbits.com |
Also added an issue to document that are now available on SchemaStore.org On Tue, Jul 15, 2014 at 2:41 PM, Thomas Davis thomasalwyndavis@gmail.com
Thomas Davis VP of Tech - Earbits - http://earbits.com |
If |
... and the tools/themes will generally not make use of any additional properties. Apart from that, the more permissive the specification is, the less powerful and successful will the standard be (due to fragmentation, confusion, etc.), right? |
Yep, the tests should be strict for tools that are trying to adhere to the On Tue, Jul 15, 2014 at 2:46 PM, Marco notifications@github.com wrote:
Thomas Davis VP of Tech - Earbits - http://earbits.com |
You probably also want to set |
Good idea, and also, awesome link! We were using our CLI tool for test but On Tue, Jul 15, 2014 at 2:54 PM, Mads Kristensen notifications@github.com
Thomas Davis VP of Tech - Earbits - http://earbits.com |
I'm glad you like it. I've just published it a few minutes ago. Still a work in progress. Let me know if you have any ideas for improvements |
Fixes the same issues that @madskristensen fixed in #105
But without:
email
section which have become obsoleteprofiles
section which did neither match the current use inresume.json
nor the style fromemail