Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Use PHPUnit\Framework\TestCase instead of PHPUnit_Framework_TestCase #33

Merged
merged 1 commit into from
Nov 13, 2017
Merged

Use PHPUnit\Framework\TestCase instead of PHPUnit_Framework_TestCase #33

merged 1 commit into from
Nov 13, 2017

Conversation

carusogabriel
Copy link
Contributor

@carusogabriel carusogabriel commented Nov 13, 2017 •
edited
Loading

I use the PHPUnit\Framework\TestCase notation instead of PHPUnit_Framework_TestCase while extending our TestCase. This will help us migrate to PHPUnit 6, that no longer support snake case class names.

I just need to bump PHPUnit version to ^4.8.35 and ^5.7, that support this namespace.

@jsor jsor merged commit 3eb63a2 into jsor:master Nov 13, 2017
@jsor
Copy link
Owner

jsor commented Nov 13, 2017

Thanks!

jsor added a commit that referenced this pull request Nov 13, 2017
@jsor
Add #33 to changelog
9c491eb
@carusogabriel carusogabriel deleted the phpunit branch November 13, 2017 12:53
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@carusogabriel @jsor