Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: Add title to iframe and aria-modal to modal. #288

Open
wants to merge 1 commit into
base: master
Choose a base branch
from
Open
Show file tree
Hide file tree
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension


Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 2 additions & 2 deletions dist/lity.css
Original file line number Diff line number Diff line change
@@ -1,6 +1,6 @@
/*! Lity - v3.0.0-dev - 2020-04-26
/*! Lity - v3.0.0-dev - 2023-07-29
* http://sorgalla.com/lity/
* Copyright (c) 2015-2020 Jan Sorgalla; Licensed MIT */
* Copyright (c) 2015-2023 Jan Sorgalla; Licensed MIT */

.lity-active,
.lity-active body {
Expand Down
8 changes: 4 additions & 4 deletions dist/lity.js
Original file line number Diff line number Diff line change
@@ -1,6 +1,6 @@
/*! Lity - v3.0.0-dev - 2020-04-26
/*! Lity - v3.0.0-dev - 2023-07-29
* http://sorgalla.com/lity/
* Copyright (c) 2015-2020 Jan Sorgalla; Licensed MIT */
* Copyright (c) 2015-2023 Jan Sorgalla; Licensed MIT */
(function(window, factory) {
if (typeof define === 'function' && define.amd) {
define(['jquery'], function($) {
Expand Down Expand Up @@ -34,7 +34,7 @@
inline: inlineHandler,
iframe: iframeHandler
},
template: '<div class="lity" role="dialog" aria-label="Dialog Window (Press escape to close)" tabindex="-1"><div class="lity-wrap" data-lity-close role="document"><div class="lity-loader" aria-hidden="true">Loading...</div><div class="lity-container"><div class="lity-content"></div><button class="lity-close" type="button" aria-label="Close (Press escape to close)" data-lity-close>&times;</button></div></div></div>'
template: '<div class="lity" role="dialog" aria-modal="true" aria-label="Dialog Window (Press escape to close)" tabindex="-1"><div class="lity-wrap" data-lity-close role="document"><div class="lity-loader" aria-hidden="true">Loading...</div><div class="lity-container"><div class="lity-content"></div><button class="lity-close" type="button" aria-label="Close (Press escape to close)" data-lity-close>&times;</button></div></div></div>'
};

var _imageRegexp = /(^data:image\/)|(\.(png|jpe?g|gif|svg|webp|bmp|ico|tiff?)(\?\S*)?$)/i;
Expand Down Expand Up @@ -161,7 +161,7 @@
iframeUrl = transferHash(hashUrl, iframeUrl);
}

return '<div class="lity-iframe-container"><iframe frameborder="0" allowfullscreen allow="autoplay; fullscreen" src="' + iframeUrl + '"/></div>';
return '<div class="lity-iframe-container"><iframe frameborder="0" allowfullscreen allow="autoplay; fullscreen" title="' + "Iframe for " + hashUrl + '" src="' + iframeUrl + '"/></div>';
}

function error(msg) {
Expand Down
4 changes: 2 additions & 2 deletions dist/lity.min.css

Some generated files are not rendered by default. Learn more about how customized files appear on GitHub.

6 changes: 3 additions & 3 deletions dist/lity.min.js

Some generated files are not rendered by default. Learn more about how customized files appear on GitHub.

4 changes: 2 additions & 2 deletions dist/plugins/facebookvideo/facebookvideo.js
Original file line number Diff line number Diff line change
@@ -1,6 +1,6 @@
/*! Lity - v3.0.0-dev - 2020-04-26
/*! Lity - v3.0.0-dev - 2023-07-29
* http://sorgalla.com/lity/
* Copyright (c) 2015-2020 Jan Sorgalla; Licensed MIT */
* Copyright (c) 2015-2023 Jan Sorgalla; Licensed MIT */
(function(window, factory) {
if (typeof define === 'function' && define.amd) {
define(['lity'], function(lity) {
Expand Down
4 changes: 2 additions & 2 deletions dist/plugins/facebookvideo/facebookvideo.min.js

Some generated files are not rendered by default. Learn more about how customized files appear on GitHub.

Loading