fix: hook into deno.json for deno dependencies #290
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
guybedford
reviewed
Apr 4, 2023
guybedford
reviewed
Apr 4, 2023
guybedford
reviewed
Apr 4, 2023
src/install/installer.ts
Outdated
| // be to have each provider declare what registries it supports, and | ||
| // construct a providers mapping at init when we detect default provider: | ||
| if (opts.defaultProvider.includes("deno")) | ||
| this.providers["npm:"] = "jspm.io"; |
There was a problem hiding this comment.
Perhaps only override this.providers['npm:'] if it doesn't already exist? But yes, this seems fine for now.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #289, or at least a first pass of a fix. This does the simplest thing for
now, which is to use the top-level imports for resolving a deno package's
secondary dependencies. This gets the
denoland:fresh/runtime.tsexampleworking, for instance.