Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: apply realpath for file: URLs in traces #52

Merged
merged 2 commits into from
Aug 1, 2021
Merged

feat: apply realpath for file: URLs in traces #52

merged 2 commits into from
Aug 1, 2021

Conversation

guybedford
Copy link
Member

This will add mappings into the generated import map for all symlinked resolutions to point to their actual path.

This will ensure symlinked paths only have a singular identity which will fix Node.js edge cases with symlinked node_modules etc. Because these are import map mappings, it would 100% support Deno too anyway.

There is also a preserveSymlinks resolver option that can be used to disable this feature if that turns out useful, but it is not currently exposed in the final generator options.

@guybedford guybedford merged commit b7df726 into main Aug 1, 2021
@guybedford guybedford deleted the realpath branch August 1, 2021 16:26
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant