Skip to content
This repository has been archived by the owner on Feb 18, 2024. It is now read-only.

Added support for npm:bootstrap@3.3.7 #975

Open
wants to merge 3 commits into
base: master
Choose a base branch
from
Open

Added support for npm:bootstrap@3.3.7 #975

Changes from all commits
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
0270e0d
Added package override for npm:bootstrap@3.3.7
Sep 16, 2016
b45ea8a
Added package override for npm:bootstrap@3.3.7
Sep 16, 2016
7c0b97d
Merge branch 'master' of https://github.com/peebeebee/registry
Sep 16, 2016
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
15 changes: 15 additions & 0 deletions package-overrides/npm/bootstrap@3.3.7.json
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -0,0 +1,15 @@
{
"main": "js/bootstrap",
"directories": {
"lib": "dist"
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This is a breaking change, do we really need this. It can be better to use dist/js/bootstrap etc in the other configurations.

},
"shim": {
"js/bootstrap": {
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

js/bootstrap -> dist/js/bootstrap.

"deps": [
"jquery",
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Invalid trailing comma.

],
"exports": "$"
}
},
"files": [ "dist" ]
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Best to leave this out as well, no reason to filter out the other files if users may find them useful.

}