Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add eslint and stricter TypeScript rules for jspsych package #3389

Open
wants to merge 11 commits into
base: main
Choose a base branch
from
Open

Add eslint and stricter TypeScript rules for jspsych package #3389

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
11 commits
Select commit Hold shift + click to select a range
c039e14
add eslint for jspsych package
joshunrau Aug 29, 2024
67b1f9b
add lint command to jspsych package scripts
joshunrau Aug 29, 2024
7aebc69
allow unused vars starting with _ in eslint config
joshunrau Aug 29, 2024
c9c3588
remove or underscore unused variables
joshunrau Aug 29, 2024
d66d0dc
set noUnusedLocals to true in jspsych tsconfig
joshunrau Aug 29, 2024
8f2ffd4
fix noUnusedLocals problems in jspsych package
joshunrau Aug 29, 2024
ad92703
fix prefer-const and no-var linting issues
joshunrau Aug 29, 2024
5eaff6c
replace Object.prototype.hasOwnProperty with Object.hasOwn
joshunrau Aug 29, 2024
148409b
fix @typescript-eslint/ban-ts-comment issues
joshunrau Aug 29, 2024
dfe8aaa
fix no-useless-escape problem
joshunrau Aug 29, 2024
9973190
add tsc --noEmit to linting command in jspsych package
joshunrau Aug 29, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
34 changes: 34 additions & 0 deletions eslint.config.js
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -0,0 +1,34 @@
import eslint from "@eslint/js";
import tslint from "typescript-eslint";

export default tslint.config(
{
ignores: [
"docs/*",
"examples/*",
"packages/*",
"!packages/jspsych",
"packages/jspsych/*",
"!packages/jspsych/src",
],
},
eslint.configs.recommended,
...tslint.configs.recommended,
{
rules: {
"@typescript-eslint/no-explicit-any": "off",
"@typescript-eslint/no-unused-vars": [
"error",
{
args: "all",
argsIgnorePattern: "^_",
caughtErrors: "all",
caughtErrorsIgnorePattern: "^_",
destructuredArrayIgnorePattern: "^_",
varsIgnorePattern: "^_",
ignoreRestSiblings: true,
},
],
},
}
);
Loading
Loading