Feature/f 33 chat implementation #15
Conversation
…implemenation-backend-communication feat: implement communication with back-end for the chatbot
src/services/api/chatbot.ts
Outdated
There was a problem hiding this comment.
I think we should use a repository instead of this service file here as well. So you should create an interface called ChatRepository in domain/repositories (with just two methods, testHealth and sendMessage) and a ChatRepositoryImpl in infrastructure/repositories. Then register the implementation in container.tsx so all the components can reach the instance without knowing the exact implementation.
There was a problem hiding this comment.
Yes, @ahmtslmngcl will continue refactoring on this part 👍
There was a problem hiding this comment.
Overall AWESOME Job! Just had a few comments regarding code style, other than that functionality, structure, finalization everything rocks! Also generally one thing I noticed in the PR, there are no return types for your functions. Please add return types for each function
const function = (): void => {...}
There was a problem hiding this comment.
I was not sure if APIError should be placed in here. Would be grateful for feedback!
There was a problem hiding this comment.
wanted to rename QueryResponse "response" field to "text" so that the call would be "response.text". But interestingly renaming it (and all its occurences) caused the system to fail when trying to interact with the chatbot.
✅ Deploy Preview for wfp-hungermap ready!
To edit notification comments on pull requests, go to your Netlify site configuration. |
Esoteriker
requested review from
Tschonti and
marinovl7
and removed request for
Tschonti,
marinovl7 and
bohdangarchu
Sorry for later PR, it took some time to refactoring the style issue: especially remove inline style and use tailwind css, it goes smoothly when bug in tailwind config fixed.
There are some points:
Regarding backend integration part @ahmtslmngcl will also plan to refactoring sth, I'm not if you need do it in this branch or open a new ticket
Typing animation is still pending, current implementation could be delete later, if text is render als markdown from backend side, we will change this component and logic
Add some css definition into global.css related to waiting AI response animation, I hope it is not big issue.
Since there are a lot custom style variable related to Chatbot, so a lot of customisation has also been added to the tailwind config
Since not all icons could be found in iconsax-react, so there is still other package be used.