Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: ✨ add custom http method request #31

Merged
merged 1 commit into from
Oct 15, 2022

Conversation

bungambohlah
Copy link
Contributor

@bungambohlah bungambohlah commented Oct 3, 2022

add an feature of custom http method request (by default use GET).
this will solve issue at #25.

And this already run gulp task for create dist files for prod ready.

And please add hacktoberfest label. Thank you

@Trekky12
Copy link
Collaborator

Trekky12 commented Oct 3, 2022

Thank you for your contribution. Could you please send your PR to the development branch instead the master branch?

@bungambohlah bungambohlah changed the base branch from master to development October 4, 2022 06:34
@bungambohlah
Copy link
Contributor Author

@Trekky12 ok noted, just changed that

@bungambohlah
Copy link
Contributor Author

Hi @Trekky12, any updates?

@Trekky12
Copy link
Collaborator

Trekky12 commented Oct 5, 2022

Thank you for your adjustments.
I will merge your PR in a few days. I assigned the hacktoberfest-accepted label so it should count for your challenge.

@bungambohlah
Copy link
Contributor Author

@Trekky12 You're welcome, ok noted that, thank you so much for your help to open this hacktoberfest as maintainer

@Trekky12 Trekky12 merged commit ea8aec7 into jstable:development Oct 15, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants