Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Bug or breaking change for BodyBuilder.LinkedResources.Add #627

Closed
agendec-com opened this issue Nov 30, 2020 · 4 comments
Closed

Bug or breaking change for BodyBuilder.LinkedResources.Add #627

agendec-com opened this issue Nov 30, 2020 · 4 comments
Labels
bug Something isn't working

Comments

@agendec-com
Copy link

agendec-com commented Nov 30, 2020 •
edited by jstedfast
Loading

To help me debug your issue, please explain:
What were you trying to do?

Add a linked resource using BodyBuilder

What happened?

Were added with Content-Disposition: attachment instead of Content-Disposition: inline.

What did you expect to happen?

Get Content-Disposition: inline.

That's what we got in MailKit ver. 2.7.0. The problem occurred after upgrading to ver. 2.10.0.

Step-by-step reproduction instructions and/or a simple test case.

oMimeEntity = oBodyBuilder.LinkedResources.Add("Filename.png", binary)
@jstedfast jstedfast transferred this issue from jstedfast/MailKit Dec 1, 2020
jstedfast added a commit that referenced this issue Dec 1, 2020
@jstedfast
Always set Content-Disposition: inline for LinkedResources
333b7a0 
Accidentally broke this in 2.10.0 due to swapping part.FileName and part.IsAttachment assignments.

Fixes issue #627
@jstedfast jstedfast added the bug Something isn't working label Dec 1, 2020
@jstedfast
Copy link
Owner

Sorry about that! I've added some new unit tests to make sure I don't break this again.

@jstedfast
Copy link
Owner

I'll probably try to make a 2.10.1 release with this fix this week/weekend.

@agendec-com
Copy link
Author

Great 👍

@jstedfast
Copy link
Owner

Released v2.10.1 to nuget.org with this fix.

@dependabot dependabot bot mentioned this issue Mar 15, 2021
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
bug Something isn't working
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@jstedfast @agendec-com