Merge from origin master #1
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
With this refactor, we now normalize the config objects at load time so that the rest of the app doesn't need to worry about all the possible variations in how the user may provide the config. For the purposes of typing, `RawWhatever` refers to the type the user is allowed to provide, and `Whatever` is the normalized type that the rest of the app will consume. E.g.
```
dependencies: ["foo", "bar"]
```
...gets normalized to...
```
dependencies: [
{
"dependency": "foo",
"accessibleTo": null
},
{
"dependency": "bar",
"accessibleTo": null
},
]
```
I also normalize the options object in the same way.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I did some refactoring in master that has some obnoxious conflicts with your changes, so I went ahead and did the merge for you.