Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Release prep 1.8.0 #39

Merged
merged 7 commits into from
Feb 28, 2023
Merged

Release prep 1.8.0 #39

merged 7 commits into from
Feb 28, 2023

Conversation

webketje
Copy link
Contributor

No description provided.

@RobLoach RobLoach merged commit b540a91 into master Feb 28, 2023
@webketje
Copy link
Contributor Author

@RobLoach I think you confused the Twig lib version with the jstransformer version in the latest tag. It goes 1.7.0 -> 1.16.0. Or was it intentional?

@RobLoach
Copy link
Member

I think having them roughly match could help people understand the version that's used.

@RobLoach
Copy link
Member

Also, I've seen a few warnings when using this in a couple applications. Is it working for you?

@webketje
Copy link
Contributor Author

I think having them roughly match could help people understand the version that's used.

@storybook addons use this model, but the difference is that storybook has control over those addons and an in-sync release process. For jstransformers the versioning is bound to get out-of-sync or limit the ability to improve the jstransformer. I would argue that departing from semver is not worth the benefit of not having to look up the version of the templating lib dependency, should the need arise. At the very least it should be prominently displayed in the README:

This project does not adhere to semantic versioning. Instead it tracks the major version of the jstranformer main dependency

Also, I've seen a few warnings when using this in a couple applications. Is it working for you?

I haven't followed up in a while, I don't remember if I tested it on a more elaborate use case than the repo's tests.

@RobLoach
Copy link
Member

I'm down with that docs change... #42

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants