Xavierm02/streams/underlying source #240
Closed
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Implemented
UnderlyingSource
, and added a trivialReadableStream
constructor that only transforms its first input into anUnderlyingSource
.A few other things were added to make this possible / easier:
JsFn<T, N, I, O>
forJsFunction
that allows to be more explicit about the JS function we expect to have, and to automatically handle theTryFromJs
andIntoJs
conversion for inputs and outputs.Todo
placeholder type for types from the spec that have not been defined yet.Manual testing
One can also add
in the
constructor
ofReadableStreamClass
and then test it withChecklist
make fmt-check
to check)