[Gtk] fix image sizing #69
Comments
webwarrior-ws
added a commit
to webwarrior-ws/geewallet
that referenced
this issue
May 23, 2024
Add BalancesPage. Fixed and simplified layout of BalancesPage. Fix layout of currency balances on balances page in Maui. Fix circle chart rendering in Maui. Use Launcher from Maui.Essentials on Maui instead of one from Xamarin.Essentials. Made click event handlers work for Gtk. Had to wrap footer label in a Frame for this. LogoImg had wrong size and it had to be resized based on the layout size. The reason is that Aspect for Image is not working in Maui/Gtk and should be fixed later (see [1]). Also added #nowarn 44 and #nowarn 1182 in BalancesPage, CircleChartView, and FrontendHelpers because of the following warnings: ``` BalancesPage.xaml.fs(503, 13): [FS1182] The value 'tapper' is unused BalancesPage.xaml.fs(443, 13): [FS1182] The value 'currentChartView' is unused BalancesPage.xaml.fs(443, 30): [FS1182] The value 'otherChartView' is unused BalancesPage.xaml.fs(439, 41): [FS1182] The value 'totalOtherFiatAmountFrame' is unused BalancesPage.xaml.fs(437, 13): [FS1182] The value 'switchingToReadOnly' is unused CircleChartView.fs(181, 35): [FS0044] This construct is deprecated. The StackLayout expansion options are deprecated; please use a Grid instead. BalancesPage.xaml.fs(53, 19): [FS1182] The value 'currencyImages' is unused CircleChartView.fs(180, 37): [FS0044] This construct is deprecated. The StackLayout expansion options are deprecated; please use a Grid instead. FrontendHelpers.fs(425, 60): [FS0044] This construct is deprecated. The StackLayout expansion options are deprecated; please use a Grid instead. ``` Co-authored-by: Parham <parhaamsaremi@gmail.com> [1] jsuarezruiz/maui-linux#69
webwarrior-ws
added a commit
to webwarrior-ws/geewallet
that referenced
this issue
May 30, 2024
Add BalancesPage. Fixed and simplified layout of BalancesPage. Fix layout of currency balances on balances page in Maui. Fix circle chart rendering in Maui. Use Launcher from Maui.Essentials on Maui instead of one from Xamarin.Essentials. Made click event handlers work for Gtk. Had to wrap footer label in a Frame for this. LogoImg had wrong size and it had to be resized based on the layout size. The reason is that Aspect for Image is not working in Maui/Gtk and should be fixed later (see [1]). Also added #nowarn 44 and #nowarn 1182 in BalancesPage, CircleChartView, and FrontendHelpers because of the following warnings: ``` BalancesPage.xaml.fs(503, 13): [FS1182] The value 'tapper' is unused BalancesPage.xaml.fs(443, 13): [FS1182] The value 'currentChartView' is unused BalancesPage.xaml.fs(443, 30): [FS1182] The value 'otherChartView' is unused BalancesPage.xaml.fs(439, 41): [FS1182] The value 'totalOtherFiatAmountFrame' is unused BalancesPage.xaml.fs(437, 13): [FS1182] The value 'switchingToReadOnly' is unused CircleChartView.fs(181, 35): [FS0044] This construct is deprecated. The StackLayout expansion options are deprecated; please use a Grid instead. BalancesPage.xaml.fs(53, 19): [FS1182] The value 'currencyImages' is unused CircleChartView.fs(180, 37): [FS0044] This construct is deprecated. The StackLayout expansion options are deprecated; please use a Grid instead. FrontendHelpers.fs(425, 60): [FS0044] This construct is deprecated. The StackLayout expansion options are deprecated; please use a Grid instead. ``` Co-authored-by: Parham <parhaamsaremi@gmail.com> [1] jsuarezruiz/maui-linux#69
webwarrior-ws
added a commit
to webwarrior-ws/geewallet
that referenced
this issue
Jun 27, 2024
Add BalancesPage. Fixed and simplified layout of BalancesPage. Fix layout of currency balances on balances page in Maui. Fix circle chart rendering in Maui. Use Launcher from Maui.Essentials on Maui instead of one from Xamarin.Essentials. Made click event handlers work for Gtk. Had to wrap footer label in a Frame for this. LogoImg had wrong size and it had to be resized based on the layout size. The reason is that Aspect for Image is not working in Maui/Gtk and should be fixed later (see [1]). Also added #nowarn 44 and #nowarn 1182 in BalancesPage, CircleChartView, and FrontendHelpers because of the following warnings: ``` BalancesPage.xaml.fs(503, 13): [FS1182] The value 'tapper' is unused BalancesPage.xaml.fs(443, 13): [FS1182] The value 'currentChartView' is unused BalancesPage.xaml.fs(443, 30): [FS1182] The value 'otherChartView' is unused BalancesPage.xaml.fs(439, 41): [FS1182] The value 'totalOtherFiatAmountFrame' is unused BalancesPage.xaml.fs(437, 13): [FS1182] The value 'switchingToReadOnly' is unused CircleChartView.fs(181, 35): [FS0044] This construct is deprecated. The StackLayout expansion options are deprecated; please use a Grid instead. BalancesPage.xaml.fs(53, 19): [FS1182] The value 'currencyImages' is unused CircleChartView.fs(180, 37): [FS0044] This construct is deprecated. The StackLayout expansion options are deprecated; please use a Grid instead. FrontendHelpers.fs(425, 60): [FS0044] This construct is deprecated. The StackLayout expansion options are deprecated; please use a Grid instead. ``` Co-authored-by: Parham <parhaamsaremi@gmail.com> [1] jsuarezruiz/maui-linux#69
webwarrior-ws
added a commit
to webwarrior-ws/geewallet
that referenced
this issue
Jul 1, 2024
Add BalancesPage. Fixed and simplified layout of BalancesPage. Fix layout of currency balances on balances page in Maui. Fix circle chart rendering in Maui. Use Launcher from Maui.Essentials on Maui instead of one from Xamarin.Essentials. Made click event handlers work for Gtk. Had to wrap footer label in a Frame for this. LogoImg had wrong size and it had to be resized based on the layout size. The reason is that Aspect for Image is not working in Maui/Gtk and should be fixed later (see [1]). Also added #nowarn 44 and #nowarn 1182 in BalancesPage, CircleChartView, and FrontendHelpers because of the following warnings: ``` BalancesPage.xaml.fs(503, 13): [FS1182] The value 'tapper' is unused BalancesPage.xaml.fs(443, 13): [FS1182] The value 'currentChartView' is unused BalancesPage.xaml.fs(443, 30): [FS1182] The value 'otherChartView' is unused BalancesPage.xaml.fs(439, 41): [FS1182] The value 'totalOtherFiatAmountFrame' is unused BalancesPage.xaml.fs(437, 13): [FS1182] The value 'switchingToReadOnly' is unused CircleChartView.fs(181, 35): [FS0044] This construct is deprecated. The StackLayout expansion options are deprecated; please use a Grid instead. BalancesPage.xaml.fs(53, 19): [FS1182] The value 'currencyImages' is unused CircleChartView.fs(180, 37): [FS0044] This construct is deprecated. The StackLayout expansion options are deprecated; please use a Grid instead. FrontendHelpers.fs(425, 60): [FS0044] This construct is deprecated. The StackLayout expansion options are deprecated; please use a Grid instead. ``` Co-authored-by: Parham <parhaamsaremi@gmail.com> [1] jsuarezruiz/maui-linux#69
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
https://learn.microsoft.com/en-us/dotnet/maui/user-interface/controls/image?view=net-maui-8.0#control-image-scaling
issue
images are not sized correctly according to aspect
https://github.com/dotnet/maui/blob/e59620b70f01fe45c0aff5d3292f4f5b6c081e2b/src/Core/src/Platform/Gtk/ImageView.cs#L48-L117
needs a refactoring
and
https://github.com/dotnet/maui/blob/e59620b70f01fe45c0aff5d3292f4f5b6c081e2b/src/Core/src/Platform/Gtk/ImageView.cs#L136-L138
needs another implementation; call to DrawPixbuf has to be changed to be clippable if Aspect = Aspect.AspectFill
The text was updated successfully, but these errors were encountered: