Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Controls.Hosting(GTK): mappings for Frame #51

Closed
wants to merge 268 commits into from

Conversation

webwarrior-ws
Copy link

Add mappers for BorderColor and CornerRadius for Frame elements so they can now have borders.

lytico and others added 30 commits May 21, 2021 04:44
…-main_init-linux-core_210521

Update to dotnet/maui/main und enhance
jsuarezruiz and others added 13 commits May 6, 2023 12:03
…rmatting

[housekeeping] Automated PR to fix formatting errors
Core(Gtk): fixes in UI element styles
Core,Controls(Gtk): implement tap/click gestures
Take VerticalOptions and HorizontalOptions of the layout into
account when calculating layout on Gtk.
This allows to customize placement of root element of the page.
Before the root layout would behave as if both options were
set to "Start".

Co-authored-by: Parham <parhaamsaremi@gmail.com>
Core,Platform(GTK): fix some problems with Layouts
…rmatting

[housekeeping] Automated PR to fix formatting errors
Remove generic catch phrase to avoid running into development
problems in the future. For instance before [1] this catch
phrase would catch NIE. The catch phrase should be removed so
it doesn't swallow useful information.

[1] jsuarezruiz@c876474
When visibility for image or label (or other views) was set to
false, they stayed visible in the application.
Implement WidthRequest and HeightRequest mappings for Image.
Core: fix Label line break mode in Gtk
@knocte
Copy link

knocte commented Jun 4, 2023

@webwarrior-ws can you rebase, to resolve the conflicts please?

Add mappers for BorderColor and CornerRadius for Frame elements
so they can now have borders.
@webwarrior-ws
Copy link
Author

@webwarrior-ws can you rebase, to resolve the conflicts please?

Rebased.

@aarani
Copy link

aarani commented Jul 10, 2023

@jsuarezruiz Is there anything else that needs to be done here?

@knocte
Copy link

knocte commented Jul 27, 2023

@jsuarezruiz can you review please? I know we can always work with our fork but we prefer to use your repo as "upstream".

@knocte
Copy link

knocte commented Sep 6, 2023

@jsuarezruiz ping

@lytico
Copy link
Collaborator

lytico commented Mar 21, 2024

@knocte wrote:

BTW by any chance can you review #51 ?

i have seen ist, but i'm not happy with this solution.

to my opinion this should be done in FrameHandler.Gtk (src/Controls/src/Core/Compatibility/Handlers/Gtk/FrameHandler.Gtk.cs) and done via Map / Update-Pattern

i made a refactoring here:
lytico#289

internal static void AddDefaultMappings()
{
#if GTK
ContentViewHandler.Mapper.AppendToMapping(
Copy link
Owner

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think will be better to manage and maintain to move this to FrameHandler.Gtk

Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

yes, this is already done in lytico#289 and part of lytico/merge/main240321

@github-actions github-actions bot locked and limited conversation to collaborators May 14, 2024
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

7 participants