fix silly unit tests

jsumners-nr · Jan 3, 2024 · 2854f7d · 2854f7d
1 parent 5f94ec3
commit 2854f7d
Show file tree

Hide file tree

Showing 4 changed files with 25 additions and 7 deletions.
diff --git a/lib/llm/chat-completion-message.js b/lib/llm/chat-completion-message.js
@@ -50,7 +50,7 @@ const createDefaultParams = {
 class LlmChatCompletionMessage extends LlmEvent {
   constructor(params = defaultParams) {
     const { agent, response, index, completionId } = params
-    super({ agent, response })
+    super(params)
 
     this.is_response = Object.keys(response) > 0
     this.conversation_id = this.conversationId(agent)

diff --git a/lib/llm/event.js b/lib/llm/event.js
@@ -129,8 +129,8 @@ class LlmEvent {
    * @returns {Promise<LlmEvent>}
    */
   static async create(params = createDefaultParams) {
-    const { agent, awsClient, response } = params
-    const event = new LlmEvent({ agent, response })
+    const { awsClient } = params
+    const event = new LlmEvent(params)
     await event.addKeyDigits(awsClient)
     return event
   }

diff --git a/tests/unit/llm/chat-completion-message.tap.js b/tests/unit/llm/chat-completion-message.tap.js
@@ -51,13 +51,22 @@ tap.beforeEach((t) => {
   t.context.response = {
     headers: {
       'x-amzn-requestid': 'request-1'
+    },
+    body: Buffer.from('{"foo":"foo"}')
+  }
+
+  t.context.invokeCommand = {
+    input: {
+      accept: 'application/json',
+      contentType: 'application/json',
+      modelId: 'amazon.titan-text-express-v1',
+      body: '{"foo":"foo"}'
     }
   }
 })
 
 tap.test('create creates a new instance', async (t) => {
-  const { agent, awsClient, response } = t.context
-  const event = await LlmChatCompletionMessage.create({ agent, awsClient, response })
+  const event = await LlmChatCompletionMessage.create(t.context)
   t.type(event, LlmEvent)
   t.type(event, LlmChatCompletionMessage)
   t.equal(event.api_key_last_four_digits, '6789')

diff --git a/tests/unit/llm/event.tap.js b/tests/unit/llm/event.tap.js
@@ -35,13 +35,22 @@ tap.beforeEach((t) => {
   t.context.response = {
     headers: {
       'x-amzn-requestid': 'request-1'
+    },
+    body: Buffer.from('{"foo":"foo"}')
+  }
+
+  t.context.invokeCommand = {
+    input: {
+      accept: 'application/json',
+      contentType: 'application/json',
+      modelId: 'amazon.titan-text-express-v1',
+      body: '{"foo":"foo"}'
     }
   }
 })
 
 tap.test('create creates a new instance', async (t) => {
-  const { agent, awsClient, response } = t.context
-  const event = await LlmEvent.create({ agent, awsClient, response })
+  const event = await LlmEvent.create(t.context)
   t.ok(event)
   t.equal(event.api_key_last_four_digits, '6789')
 })