Skip to content

Commit

Permalink
address feedback
Browse files Browse the repository at this point in the history
  • Loading branch information
@jsumners-nr
jsumners-nr committed Mar 11, 2024
1 parent 7119c2f commit e61bd2f
Show file tree
Hide file tree
Showing 2 changed files with 30 additions and 0 deletions.
21 changes: 21 additions & 0 deletions tests/unit/llm/bedrock-response.tap.js
View file
Original file line number Diff line number Diff line change
Expand Up @@ -99,6 +99,7 @@ tap.test('non-conforming response is handled gracefully', async (t) => {
t.same(res.headers, undefined)
t.equal(res.id, undefined)
t.equal(res.inputTokenCount, undefined)
t.equal(res.outputTokenCount, undefined)
t.equal(res.requestId, undefined)
t.equal(res.statusCode, 200)
})
Expand All @@ -110,6 +111,8 @@ tap.test('ai21 malformed responses work', async (t) => {
t.equal(res.finishReason, undefined)
t.same(res.headers, t.context.response.response.headers)
t.equal(res.id, undefined)
t.equal(res.inputTokenCount, 25)
t.equal(res.outputTokenCount, 25)
t.equal(res.requestId, 'aws-request-1')
t.equal(res.statusCode, 200)
})
Expand All @@ -122,6 +125,8 @@ tap.test('ai21 complete responses work', async (t) => {
t.equal(res.finishReason, 'done')
t.same(res.headers, t.context.response.response.headers)
t.equal(res.id, 'ai21-response-1')
t.equal(res.inputTokenCount, 25)
t.equal(res.outputTokenCount, 25)
t.equal(res.requestId, 'aws-request-1')
t.equal(res.statusCode, 200)
})
Expand All @@ -133,6 +138,8 @@ tap.test('claude malformed responses work', async (t) => {
t.equal(res.finishReason, undefined)
t.same(res.headers, t.context.response.response.headers)
t.equal(res.id, undefined)
t.equal(res.inputTokenCount, 25)
t.equal(res.outputTokenCount, 25)
t.equal(res.requestId, 'aws-request-1')
t.equal(res.statusCode, 200)
})
Expand All @@ -145,6 +152,8 @@ tap.test('claude complete responses work', async (t) => {
t.equal(res.finishReason, 'done')
t.same(res.headers, t.context.response.response.headers)
t.equal(res.id, undefined)
t.equal(res.inputTokenCount, 25)
t.equal(res.outputTokenCount, 25)
t.equal(res.requestId, 'aws-request-1')
t.equal(res.statusCode, 200)
})
Expand All @@ -156,6 +165,8 @@ tap.test('cohere malformed responses work', async (t) => {
t.equal(res.finishReason, undefined)
t.same(res.headers, t.context.response.response.headers)
t.equal(res.id, undefined)
t.equal(res.inputTokenCount, 25)
t.equal(res.outputTokenCount, 25)
t.equal(res.requestId, 'aws-request-1')
t.equal(res.statusCode, 200)
})
Expand All @@ -168,6 +179,8 @@ tap.test('cohere complete responses work', async (t) => {
t.equal(res.finishReason, 'done')
t.same(res.headers, t.context.response.response.headers)
t.equal(res.id, 'cohere-response-1')
t.equal(res.inputTokenCount, 25)
t.equal(res.outputTokenCount, 25)
t.equal(res.requestId, 'aws-request-1')
t.equal(res.statusCode, 200)
})
Expand All @@ -179,6 +192,8 @@ tap.test('llama2 malformed responses work', async (t) => {
t.equal(res.finishReason, undefined)
t.same(res.headers, t.context.response.response.headers)
t.equal(res.id, undefined)
t.equal(res.inputTokenCount, 25)
t.equal(res.outputTokenCount, 25)
t.equal(res.requestId, 'aws-request-1')
t.equal(res.statusCode, 200)
})
Expand All @@ -191,6 +206,8 @@ tap.test('llama2 complete responses work', async (t) => {
t.equal(res.finishReason, 'done')
t.same(res.headers, t.context.response.response.headers)
t.equal(res.id, undefined)
t.equal(res.inputTokenCount, 25)
t.equal(res.outputTokenCount, 25)
t.equal(res.requestId, 'aws-request-1')
t.equal(res.statusCode, 200)
})
Expand All @@ -202,6 +219,8 @@ tap.test('titan malformed responses work', async (t) => {
t.equal(res.finishReason, undefined)
t.same(res.headers, t.context.response.response.headers)
t.equal(res.id, undefined)
t.equal(res.inputTokenCount, 25)
t.equal(res.outputTokenCount, 25)
t.equal(res.requestId, 'aws-request-1')
t.equal(res.statusCode, 200)
})
Expand All @@ -214,6 +233,8 @@ tap.test('titan complete responses work', async (t) => {
t.equal(res.finishReason, 'done')
t.same(res.headers, t.context.response.response.headers)
t.equal(res.id, undefined)
t.equal(res.inputTokenCount, 25)
t.equal(res.outputTokenCount, 25)
t.equal(res.requestId, 'aws-request-1')
t.equal(res.statusCode, 200)
})
Expand Down
9 changes: 9 additions & 0 deletions tests/unit/llm/stream-handler.tap.js
View file
Original file line number Diff line number Diff line change
Expand Up @@ -118,6 +118,7 @@ tap.test('handles claude streams', async (t) => {
t.equal(br.requestId, 'aws-req-1')
t.equal(br.statusCode, 200)
t.equal(br.inputTokenCount, 5)
t.equal(br.outputTokenCount, 10)
})

tap.test('handles cohere streams', async (t) => {
Expand Down Expand Up @@ -165,6 +166,8 @@ tap.test('handles cohere streams', async (t) => {
t.equal(br.finishReason, 'done')
t.equal(br.requestId, 'aws-req-1')
t.equal(br.statusCode, 200)
t.equal(br.inputTokenCount, 5)
t.equal(br.outputTokenCount, 10)
})

tap.test('handles cohere embedding streams', async (t) => {
Expand Down Expand Up @@ -217,6 +220,8 @@ tap.test('handles cohere embedding streams', async (t) => {
t.equal(br.finishReason, undefined)
t.equal(br.requestId, 'aws-req-1')
t.equal(br.statusCode, 200)
t.equal(br.inputTokenCount, 5)
t.equal(br.outputTokenCount, 10)
})

tap.test('handles llama2 streams', async (t) => {
Expand Down Expand Up @@ -257,6 +262,8 @@ tap.test('handles llama2 streams', async (t) => {
t.equal(br.finishReason, 'done')
t.equal(br.requestId, 'aws-req-1')
t.equal(br.statusCode, 200)
t.equal(br.inputTokenCount, 5)
t.equal(br.outputTokenCount, 10)
})

tap.test('handles titan streams', async (t) => {
Expand Down Expand Up @@ -307,4 +314,6 @@ tap.test('handles titan streams', async (t) => {
t.equal(br.finishReason, 'done')
t.equal(br.requestId, 'aws-req-1')
t.equal(br.statusCode, 200)
t.equal(br.inputTokenCount, 5)
t.equal(br.outputTokenCount, 10)
})

0 comments on commit e61bd2f

Please sign in to comment.