-
Notifications
You must be signed in to change notification settings - Fork 33
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Update to use emojilib v3 #66
Conversation
This will fix #44, presumably just because the data source is updated.
Also, had a reference to emoji.char which no longer exists.
Emoji search is significantly slower since this PR was merged. Hypothesized culprits:
If 1. is true, then precomputing a lookup during build would solve it. |
Here is a fork that uses v2 if anyone has the same issue in the future: https://github.com/devnoname120/alfred-emoji/releases/tag/v1.11.0 |
Please work with us instead of immediately starting forks. There has not been a new version published that utilizes the code in this PR as yet. There is plenty of time to work out issues before such happens. |
I don't plan to maintain the fork. It's just a quick and dirty solution (mostly for personal use) because I don't plan to invest time fixing the root issue in the short term. |
@jsumners I can confirm that the performance issues I was experiencing are resolved now. |
No description provided.