Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update to use emojilib v3 #66

Merged
merged 5 commits into from
Jan 26, 2022
Merged

Update to use emojilib v3 #66

merged 5 commits into from
Jan 26, 2022

Conversation

jsumners
Copy link
Owner

No description provided.

kemayo and others added 5 commits June 27, 2021 12:27
This will fix #44, presumably just because the data source is updated.
Also, had a reference to emoji.char which no longer exists.
@jsumners jsumners merged commit 1adf245 into master Jan 26, 2022
@jsumners jsumners deleted the pr-60-tweaks branch January 26, 2022 15:03
@devnoname120
Copy link

devnoname120 commented Jan 27, 2022

Emoji search is significantly slower since this PR was merged.

Hypothesized culprits:

  1. Iterating on the objects of orderedEmoji is slower than on the primitive type strings of emojiNames.
  2. The new lib has an order of magnitude more emojis. Search is O(n) where n is the number of emojis. It's possible that n got considerably bigger.

If 1. is true, then precomputing a lookup during build would solve it.
If 2. is true, we could use some kind of hash structure to precompute first 2-3 search letters, and then narrow down the remaining matches using previous method. This should mostly the solve the speed issues.

@devnoname120
Copy link

Here is a fork that uses v2 if anyone has the same issue in the future: https://github.com/devnoname120/alfred-emoji/releases/tag/v1.11.0

@jsumners
Copy link
Owner Author

Please work with us instead of immediately starting forks. There has not been a new version published that utilizes the code in this PR as yet. There is plenty of time to work out issues before such happens.

@devnoname120
Copy link

I don't plan to maintain the fork. It's just a quick and dirty solution (mostly for personal use) because I don't plan to invest time fixing the root issue in the short term.

@devnoname120 devnoname120 mentioned this pull request Jan 31, 2022
@devnoname120
Copy link

@jsumners I can confirm that the performance issues I was experiencing are resolved now.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants