Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add genpack step #75

Closed
wants to merge 1 commit into from
Closed

Add genpack step #75

wants to merge 1 commit into from

Conversation

miharekar
Copy link

Probably required since #69.

But I had to do that in order for build to succeed.

@jsumners
Copy link
Owner

npm run build merely runs ./build.sh, which includes:

alfred-emoji/build.sh

Lines 25 to 26 in 8ada3e8

echo "Creating emoji pack ..."
node ../lib/genpack.js

We shouldn't need to add "npm run genpack" to the instructions. It looks like the actual problem is a webpack problem (ugh, I hate that we have to rely on that tool):

> webpack
> webpack

assets by status 1.86 KiB [cached] 1 asset
./src/emoji.js 959 bytes [built] [code generated]
./src/search.js 3.38 KiB [built] [code generated]
./src/utils.js 154 bytes [built] [code generated]

ERROR in ./src/search.js 3:18-46
Module not found: Error: Can't resolve './emoji.pack.json' in '/Users/jsumners/Projects/oss/alfred-emoji/src'
resolve './emoji.pack.json' in '/Users/jsumners/Projects/oss/alfred-emoji/src'
  using description file: /Users/jsumners/Projects/oss/alfred-emoji/package.json (relative path: ./src)
    Field 'browser' doesn't contain a valid alias configuration
    using description file: /Users/jsumners/Projects/oss/alfred-emoji/package.json (relative path: ./src/emoji.pack.json)
      no extension
        Field 'browser' doesn't contain a valid alias configuration
        /Users/jsumners/Projects/oss/alfred-emoji/src/emoji.pack.json doesn't exist
      .js
        Field 'browser' doesn't contain a valid alias configuration
        /Users/jsumners/Projects/oss/alfred-emoji/src/emoji.pack.json.js doesn't exist
      .json
        Field 'browser' doesn't contain a valid alias configuration
        /Users/jsumners/Projects/oss/alfred-emoji/src/emoji.pack.json.json doesn't exist
      .wasm
        Field 'browser' doesn't contain a valid alias configuration
        /Users/jsumners/Projects/oss/alfred-emoji/src/emoji.pack.json.wasm doesn't exist
      as directory
        /Users/jsumners/Projects/oss/alfred-emoji/src/emoji.pack.json doesn't exist
 @ ./src/emoji.js 4:15-34

webpack 5.67.0 compiled with 1 error in 358 ms

@miharekar
Copy link
Author

Ah, well, that's out of scope of my knowledge. I just know what fixed it for me 😅

@jsumners
Copy link
Owner

Thank you for the contribution. It showed a problem in the build process. This PR is superseded by #77

@jsumners jsumners closed this Jan 31, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants