-
-
Notifications
You must be signed in to change notification settings - Fork 201
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
chore: 🤖 upgrade to angular v16 #661
Conversation
|
fixed merge conflicts in #642 and upgraded to Angular v16 Manually checked And I ran these tests locally: npm run ci:test -- --skipNxCache
npm run ci:build -- --skipNxCache
npm run ci:lint -- --skipNxCache
npm run ci:e2e -- --skipNxCache
npm run lint
npm run e2e Green CI @ https://github.com/chimurai/transloco/actions/runs/5164381238 |
Think the peerDependencies need to be update as well? - "@angular/core": ">=13.0.0",
+ "@angular/core": ">=16.0.0", |
- npx nx migrate @nrwl/angular@15 - npx nx migrate @ngneat/spectator@12.2.1 - update jest v28 - update postcss BREAKING CHANGE: 🧨 Angular 14
BREAKING CHANGE: 🧨 Angular 15 - npx nx migrate @nrwl/angular@15.9.2 - npx nx migrate @nrwl/jest@15.9.2 - npx nx migrate @ngneat/spectator@14.0.0 - npx nx migrate nx@15.9.2
- npx nx migrate @angular/cli@16.0.4 - npx nx migrate @nrwl/angular@16.3.2 - npx nx migrate @ngneat/spectator@15.0.0 - remove "defaultProject" - https://github.com/angular/angular-cli/blob/main/CHANGELOG.md#1600-2023-05-03 BREAKING CHANGE: 🧨 Angular 16
I there a good reason to update nx to version 15 and not the latest version? |
@alexfriesen Meanwhile NG16 got released, so this PR was opened to solve merge conflicts and upgraded to NG16. Didn't update NX to latest to keep the scope small. And to be honest; I can't keep spending time to keep this PR up-to-date... |
@chimurai First of all, thank you for the time spent on the and the previous PR. I'll do my best to push this forward ASAP. Thanks again for the PR :) |
I appreciate @chimurai for handling the PR and @shaharkazaz for successfully merging it. I'm excited about getting it published on npm and trying out the latest Angular version. |
Totally recognizable and relatable @shaharkazaz; Really appreciate the work and care you've put into this project. 🙏 Hopefully community contributions help out to relief the maintenance burden a bit. (OSS ftw 😊) |
Thanks guys. |
Hello, @shaharkazaz, when can we anticipate the next npm release? |
@anikets43 As soon as I have time to complete the transition. I'm about half way there. |
PR Checklist
Please check if your PR fulfills the following requirements:
PR Type
What kind of change does this PR introduce?
What is the current behavior?
Issue Number: N/A
What is the new behavior?
Update Angular to v16
Update nx to v15.9.2
Does this PR introduce a breaking change?
Other information