Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore: 🤖 upgrade to angular v16 #661

Merged
merged 4 commits into from
Jun 17, 2023
Merged

chore: 🤖 upgrade to angular v16 #661

merged 4 commits into from
Jun 17, 2023

Conversation

chimurai
Copy link
Contributor

@chimurai chimurai commented Jun 3, 2023

PR Checklist

Please check if your PR fulfills the following requirements:

PR Type

What kind of change does this PR introduce?

[ ] Bugfix
[ ] Feature
[ ] Code style update (formatting, local variables)
[ ] Refactoring (no functional changes, no api changes)
[x] Build related changes
[x] CI related changes
[ ] Documentation content changes
[ ] Other... Please describe:

What is the current behavior?

Issue Number: N/A

What is the new behavior?

Update Angular to v16
Update nx to v15.9.2

Does this PR introduce a breaking change?

[x] Yes
[ ] No

Other information

@stackblitz
Copy link

stackblitz bot commented Jun 3, 2023

Review PR in StackBlitz Codeflow Run & review this pull request in StackBlitz Codeflow.

@chimurai
Copy link
Contributor Author

chimurai commented Jun 3, 2023

fixed merge conflicts in #642 and upgraded to Angular v16

Manually checked npm run start

And I ran these tests locally:

npm run ci:test -- --skipNxCache
npm run ci:build -- --skipNxCache
npm run ci:lint -- --skipNxCache
npm run ci:e2e -- --skipNxCache
npm run lint
npm run e2e

Green CI @ https://github.com/chimurai/transloco/actions/runs/5164381238

@chimurai chimurai mentioned this pull request Jun 3, 2023
3 tasks
@chimurai
Copy link
Contributor Author

chimurai commented Jun 3, 2023

Think the peerDependencies need to be update as well?

-   "@angular/core": ">=13.0.0", 
+   "@angular/core": ">=16.0.0", 

https://github.com/ngneat/transloco/blob/9b3af32d2147c6d5c15aa101c7a2c497c2789128/libs/transloco-locale/package.json#L27-L29

chimurai added 4 commits June 11, 2023 10:08
- npx nx migrate @nrwl/angular@15
- npx nx migrate @ngneat/spectator@12.2.1
- update jest v28
- update postcss

BREAKING CHANGE: 🧨 Angular 14
BREAKING CHANGE: 🧨 Angular 15

- npx nx migrate @nrwl/angular@15.9.2
- npx nx migrate @nrwl/jest@15.9.2
- npx nx migrate @ngneat/spectator@14.0.0
- npx nx migrate nx@15.9.2
- npx nx migrate @angular/cli@16.0.4
- npx nx migrate @nrwl/angular@16.3.2
- npx nx migrate @ngneat/spectator@15.0.0
- remove "defaultProject" - https://github.com/angular/angular-cli/blob/main/CHANGELOG.md#1600-2023-05-03

BREAKING CHANGE: 🧨 Angular 16
@alexfriesen
Copy link
Contributor

I there a good reason to update nx to version 15 and not the latest version?

@chimurai
Copy link
Contributor Author

@alexfriesen
The original PR #642 was opened on April 2nd to upgrade to NG15.
At that time NX 15 was the latest.

Meanwhile NG16 got released, so this PR was opened to solve merge conflicts and upgraded to NG16.

Didn't update NX to latest to keep the scope small.

And to be honest; I can't keep spending time to keep this PR up-to-date...

@shaharkazaz
Copy link
Collaborator

@chimurai First of all, thank you for the time spent on the and the previous PR.
It's not unnoticed.
As a single maintainer to a big repo such as this and other projects it's hard to get to things considering the fact that I also have to work and have a life with my family 😂

I'll do my best to push this forward ASAP.
Not sure if you noticed but I'm trying to push thing forward in the last couple of weeks, but TBH it's hard.

Thanks again for the PR :)

@shaharkazaz shaharkazaz merged commit 08db7e7 into jsverse:master Jun 17, 2023
@anikets43
Copy link

I appreciate @chimurai for handling the PR and @shaharkazaz for successfully merging it. I'm excited about getting it published on npm and trying out the latest Angular version.

@chimurai
Copy link
Contributor Author

Totally recognizable and relatable @shaharkazaz;
All of our time is limited and valuable.

Really appreciate the work and care you've put into this project. 🙏

Hopefully community contributions help out to relief the maintenance burden a bit. (OSS ftw 😊)

@shaharkazaz
Copy link
Collaborator

Thanks guys.
There is a bit more work do be done there before releasing the new version (some deprecations and reactors, docs etc) but I'm aiming for this week 💪

@anikets43
Copy link

Hello, @shaharkazaz, when can we anticipate the next npm release?

@shaharkazaz
Copy link
Collaborator

@anikets43 As soon as I have time to complete the transition. I'm about half way there.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants