Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

snap_x_tolerance and snap_y_tolerance for extra flexibility in table extraction #475

Closed
ratulbhadury opened this issue Jul 19, 2021 · 3 comments
Labels
feature-request All feature requests receive this label initially, can be upgraded to "enhancement"

Comments

@ratulbhadury
Copy link

Hi Jeremy

Before I get into my issue, I just want to say (again), thanks for all your efforts on this package. I've found it much easier to use than many of the other similar python libraries.

I'm using v0.5.28. I'm faced with a scenario where I would like to specify different tolerances for the x and y directions when it comes to 'snapping' parallel lines into one.

I see the exact same request had been made some years ago, and it looks as it had been accepted and implemented back then into the v0.6 branch, but hasn't made its way into the master one.

Do you have plans to include this into the master branch? If not, can you suggest any workarounds for how I could get this to work?

Thanks and kind regards,

Ratul

@samkit-jain samkit-jain added the feature-request All feature requests receive this label initially, can be upgraded to "enhancement" label Jul 21, 2021
@samkit-jain
Copy link
Collaborator

Yes, it is a useful feature request. Feel free to raise a PR if you have a solution in mind.

@ratulbhadury
Copy link
Author

Hi @samkit-jain

I haven't investigated a solution yet, but I have seen that this feature has been previously requested, and is in fact part of the v0.6 alpha branch.

I have not yet looked deeply into the architecture of the v0.6 branch and its differences with the stable branch, but would it be possible to include this feature that is already in that branch, and merge it into the stable branch? Please refer to PR #51.

Many thanks

jsvine added a commit that referenced this issue Dec 2, 2021
Based largely on @dustindall's work in PR #51, adapted to current code.

Also resolves issue #475.
@jsvine
Copy link
Owner

jsvine commented Dec 24, 2021

Hi @ratulbhadury, and thanks again for this suggestion. Your requested feature is now available in v0.6.0! See #553 for details.

@jsvine jsvine closed this as completed Dec 24, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
feature-request All feature requests receive this label initially, can be upgraded to "enhancement"
Projects
None yet
Development

No branches or pull requests

3 participants