Add --laparams to CLI (and make related tweaks) #407
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This commit adds an `--laparams` flag to the pdfplumber CLI, giving it more feature parity with the core library. To do so, it makes some internal changes to `convert.py`, including changing the list of objects to convert from *a predefined default list* to *all types extracted*.
Codecov Report
@@ Coverage Diff @@
## develop #407 +/- ##
===========================================
+ Coverage 98.26% 98.28% +0.02%
===========================================
Files 10 10
Lines 1207 1226 +19
===========================================
+ Hits 1186 1205 +19
Misses 21 21
Continue to review full report at Codecov.
|
samkit-jain
reviewed
Apr 10, 2021
A vestige of a previous, unpursued approach.
samkit-jain
approved these changes
Apr 12, 2021
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This commit adds an
--laparamsflag to the pdfplumber CLI, giving it more feature parity with the core library. To do so, it makes some internal changes toconvert.py, including changing the list of objects to convert from a predefined default list to all types extracted. It also changes the order ofconvert_csv's output so that objects are sorted first by page number (rather than object type).