Make whitespace checking more robust #88
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Currently only looks for the literal " " and fails on other whitespace characters like "\xa0" (non-breaking space). This causes
extract_words()
to not split words on these characters, and also to pick up stray whitespace as words. Python's builtin string methodisspace()
is perfect for this.I've never actually written a test before but from looking at some of yours, this might do the trick. I've attached an example document below. Currently
len(words) == 32
but from looking at the document you can see it should be 25, and indeed it is when usingisspace()
.whitespace_test.pdf