Merge pull request #746 from hallzac2/allow-fieldset-to-have-role-of-…

…radiogroup Update recommended config to allow fieldset to have the radiogroup role
jsx-eslint · Apr 7, 2021 · 9eea790 · 9eea790
2 parents 6b9e89f + d927625
commit 9eea790
Show file tree

Hide file tree

Showing 2 changed files with 3 additions and 0 deletions.
diff --git a/__tests__/src/rules/no-noninteractive-element-to-interactive-role-test.js b/__tests__/src/rules/no-noninteractive-element-to-interactive-role-test.js
@@ -448,6 +448,8 @@ ruleTester.run(`${ruleName}:recommended`, rule, {
     { code: '<li role="row" />;' },
     { code: '<li role="treeitem" />;' },
     { code: '<Component role="treeitem" />;' },
+    { code: '<fieldset role="radiogroup" />;' },
+    { code: '<fieldset role="presentation" />;' },
   ]
     .map(ruleOptionsMapperFactory(recommendedOptions))
     .map(parserOptionsMapper),

diff --git a/src/index.js b/src/index.js
@@ -164,6 +164,7 @@ module.exports = {
             li: ['menuitem', 'option', 'row', 'tab', 'treeitem'],
             table: ['grid'],
             td: ['gridcell'],
+            fieldset: ['radiogroup', 'presentation'],
           },
         ],
         'jsx-a11y/no-noninteractive-tabindex': [