[patch] mouse-events-have-key-events: rport the attribute, not the …

…node This has the side benefit of making the error message ordering consistent, since when both were on the JSXOpeningElement, since eslint/node combinations ordered the errors inconsistently
jsx-eslint · Aug 11, 2023 · eadd70c · eadd70c
1 parent 0c278f4
commit eadd70c
Show file tree

Hide file tree

Showing 2 changed files with 6 additions and 6 deletions.
diff --git a/__tests__/src/rules/mouse-events-have-key-events-test.js b/__tests__/src/rules/mouse-events-have-key-events-test.js
@@ -20,19 +20,19 @@ const ruleTester = new RuleTester();
 
 const mouseOverError = {
   message: 'onMouseOver must be accompanied by onFocus for accessibility.',
-  type: 'JSXOpeningElement',
+  type: 'JSXAttribute',
 };
 const pointerEnterError = {
   message: 'onPointerEnter must be accompanied by onFocus for accessibility.',
-  type: 'JSXOpeningElement',
+  type: 'JSXAttribute',
 };
 const mouseOutError = {
   message: 'onMouseOut must be accompanied by onBlur for accessibility.',
-  type: 'JSXOpeningElement',
+  type: 'JSXAttribute',
 };
 const pointerLeaveError = {
   message: 'onPointerLeave must be accompanied by onBlur for accessibility.',
-  type: 'JSXOpeningElement',
+  type: 'JSXAttribute',
 };
 
 ruleTester.run('mouse-events-have-key-events', rule, {

diff --git a/src/rules/mouse-events-have-key-events.js b/src/rules/mouse-events-have-key-events.js
@@ -67,7 +67,7 @@ export default ({
 
         if (hasOnFocus === false || onFocusValue === null || onFocusValue === undefined) {
           context.report({
-            node,
+            node: getProp(attributes, firstHoverInHandlerWithValue),
             message: `${firstHoverInHandlerWithValue} must be accompanied by onFocus for accessibility.`,
           });
         }
@@ -86,7 +86,7 @@ export default ({
 
         if (hasOnBlur === false || onBlurValue === null || onBlurValue === undefined) {
           context.report({
-            node,
+            node: getProp(attributes, firstHoverOutHandlerWithValue),
             message: `${firstHoverOutHandlerWithValue} must be accompanied by onBlur for accessibility.`,
           });
         }