-
-
Notifications
You must be signed in to change notification settings - Fork 637
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
v5.1.0 included breaking change! #283
Comments
Thanks for reporting - @evcohen, this will impact all users of the airbnb eslint config. I've created a new tag for @jessebeach, I'm still not sure if #236 was breaking or not; I'm proceeding under the assumption that it was not. After v5.1.1 is published, I'll merge the tag back into master so as to incorporate the changelog changes (without leaving the tag orphaned). |
Thanks for confirming! That was my interpretation when reading the diff. |
Published v5.1.1. |
I put up #285 to get stamped so i can merge the tag in properly on the command line. |
ah thank you for taking care of this!!! my file system must have had the files removed when i checked out the 5.0.1 tag 😞 |
The 5.0.1 tag sits on the 6.0.0 tag, so maybe the checkout just failed? |
extends airbnb still shows this error but if you click the anchor you get to 404 page on github. |
@inoas it shouldn't if |
well I include a11y independent of airbnb... this will soon be resolve I guess. |
It seems that the commit removing
href-no-hash
was included in the v5.1.0 release.Note: Originally found by @Misiur in airbnb/javascript#1474.
The text was updated successfully, but these errors were encountered: