Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

v5.1.0 included breaking change! #283

Closed
Arcanemagus opened this issue Jul 3, 2017 · 10 comments
Closed

v5.1.0 included breaking change! #283

Arcanemagus opened this issue Jul 3, 2017 · 10 comments
Assignees
Labels

Comments

@Arcanemagus
Copy link
Contributor

It seems that the commit removing href-no-hash was included in the v5.1.0 release.

Note: Originally found by @Misiur in airbnb/javascript#1474.

@ljharb
Copy link
Member

ljharb commented Jul 3, 2017

Thanks for reporting - @evcohen, this will impact all users of the airbnb eslint config. I've created a new tag for v5.1.1 that is publishable, and reverts the breaking changes, and have pushed it up - if there's no objections, I'd like to publish this ASAP. (I've included safe-publish-latest which ensures that the backport won't accidentally publish as "latest", since v6 is latest).

@jessebeach, I'm still not sure if #236 was breaking or not; I'm proceeding under the assumption that it was not.

After v5.1.1 is published, I'll merge the tag back into master so as to incorporate the changelog changes (without leaving the tag orphaned).

@jessebeach
Copy link
Collaborator

I'm still not sure if #236 was breaking or not; I'm proceeding under the assumption that it was not.

@ljharb It shouldn't be. It adds options, but the fallback is the old behavior.

@ljharb
Copy link
Member

ljharb commented Jul 3, 2017

Thanks for confirming! That was my interpretation when reading the diff.

@ljharb
Copy link
Member

ljharb commented Jul 4, 2017

Published v5.1.1.

@ljharb ljharb closed this as completed Jul 4, 2017
@ljharb ljharb mentioned this issue Jul 4, 2017
@ljharb
Copy link
Member

ljharb commented Jul 4, 2017

I put up #285 to get stamped so i can merge the tag in properly on the command line.

@beefancohen
Copy link
Contributor

ah thank you for taking care of this!!! my file system must have had the files removed when i checked out the 5.0.1 tag 😞

@ljharb
Copy link
Member

ljharb commented Jul 7, 2017

The 5.0.1 tag sits on the 6.0.0 tag, so maybe the checkout just failed?

@inoas
Copy link

inoas commented Sep 1, 2017

extends airbnb still shows this error but if you click the anchor you get to 404 page on github.

@ljharb
Copy link
Member

ljharb commented Sep 1, 2017

@inoas it shouldn't if npm ls exits successfully.

@inoas
Copy link

inoas commented Sep 1, 2017

well I include a11y independent of airbnb... this will soon be resolve I guess.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

No branches or pull requests

5 participants