Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Contradicting linting issue with jsx-a11y/role-supports-aria-props #704

Closed
miyagiborn opened this issue Jun 19, 2020 · 4 comments · Fixed by #705 or A11yance/aria-query#63
Closed

Contradicting linting issue with jsx-a11y/role-supports-aria-props #704

miyagiborn opened this issue Jun 19, 2020 · 4 comments · Fixed by #705 or A11yance/aria-query#63
Assignees
@jessebeach

Comments

@miyagiborn
Copy link

miyagiborn commented Jun 19, 2020 •
edited
Loading

Since the latest update, getting linting issue:

Elements with the ARIA role "heading" must have the following attributes defined: aria-level jsx-a11y/role-has-required-aria-props

After adding the aria-level, getting a contradicting error:

The attribute aria-level is not supported by the role heading jsx-a11y/role-supports-aria-props
@andeykovayov
Copy link

Have exactly the same issue!
Thanks @leducquan

@jessebeach
Copy link
Collaborator

I know exactly why this is happening :/

Fixing it now.

jessebeach added a commit that referenced this issue Jun 19, 2020
@jessebeach
Fix aria-level allowed on elements wit role heading (#704)
81970cb
This was referenced Jun 19, 2020
Merged
Merged
@jessebeach
Copy link
Collaborator

jessebeach closed this in A11yance/aria-query#63 11 minutes ago

Github has started auto-closing linked issues?

@jessebeach jessebeach reopened this Jun 19, 2020
@ljharb
Copy link
Member

ljharb commented Jun 19, 2020

When the merger has close rights on the linked issue, it's always auto-closed it afaik.

ljharb pushed a commit that referenced this issue Jun 19, 2020
@jessebeach @ljharb
Fix aria-level allowed on elements wit role heading (#704)
d528e8c
jessebeach added a commit that referenced this issue Jun 19, 2020
@jessebeach
Merge pull request #705 from jsx-eslint/fix-heading-error
b82b1bd 
Fix aria-level error for the heading role (#704)
@jessebeach jessebeach mentioned this issue Jun 19, 2020
Merged
@dependabot dependabot bot mentioned this issue Jun 22, 2020
Closed
@dependabot-preview dependabot-preview bot mentioned this issue Jun 22, 2020
Merged
This was referenced Mar 10, 2021
Closed
Closed
@dependabot dependabot bot mentioned this issue Mar 17, 2021
Merged
This was referenced Oct 4, 2021
Merged
Merged
Merged
@dependabot dependabot bot mentioned this issue Oct 25, 2021
Closed
@dependabot dependabot bot mentioned this issue Aug 10, 2022
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@jessebeach jessebeach

Labels
None yet
Projects
None yet
Milestone
No milestone
4 participants
@ljharb @jessebeach @miyagiborn @andeykovayov