Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Be able to specify component and props for rules like href-no-hash #76

Closed
lencioni opened this issue Aug 16, 2016 · 0 comments
Closed

Comments

@lencioni
Copy link
Contributor

We have a component that takes a couple of href props, like hrefLeft and hrefRight. These end up being used further down in the chain as href attributes, so it would be nice to be able to specify this in the configuration for this rule so it can be checked.

There may be other rules that could use a similar style of configuration.

cc @wyattdanger

beefancohen added a commit that referenced this issue Oct 12, 2016
* [new] - Add support to pass prop options down for `href-no-hash` rule.

Fixes #76

* [new] - Update all schemas to use objects so that they are extensible in the future.

This will ensure that adding properties to the config won’t be a
breaking change for all rules.

* [docs] - Update docs to reflect new schemas.

* Remove Link from anchor-has-content in favor of eslintrc customization.

* Allow customization of keys for components and props for schema factories.

* Camelcase specialLink for consistency.

* Refactor schema generation to be more composable and local to the rules.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

2 participants