-
-
Notifications
You must be signed in to change notification settings - Fork 637
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
label-has-associated-control regression #962
Labels
Comments
I have been unable to reproduce this issue, testing against the latest released version It's possible this was fixed by a08fbcc / #1004 Nonetheless, I might put up a PR that adds extra test coverage for this area for non-nested usage. ExampleSee https://stackblitz.com/edit/vitejs-vite-vriesx?file=src%2Fcomponent.tsx /* eslint
"jsx-a11y/label-has-associated-control": [
"error", { "controlComponents": ["InputComponent"] },
],
*/
const InputComponents = () => <input />;
function MyComponent() {
return (
<label>
My label
<InputComponents />
</label>
);
}
export default MyComponent; |
lb-
added a commit
to lb-/eslint-plugin-jsx-a11y
that referenced
this issue
Oct 22, 2024
- Add test cases for non-nested labels with custom controlComponents - Fix small typo in mayContainChildComponent util - See jsx-eslint#962
ljharb
pushed a commit
to lb-/eslint-plugin-jsx-a11y
that referenced
this issue
Oct 25, 2024
- Add test cases for non-nested labels with custom controlComponents - Fix small typo in mayContainChildComponent util - See jsx-eslint#962
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Looks like
controlComponents
option is no longer respected.The following code now gives
A form label must be associated with a control
warning:Started happening after upgrade from 6.7.1 to 6.8.0.
The text was updated successfully, but these errors were encountered: