Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add failing test for autocomplete with dynamic type #721

Merged
merged 2 commits into from
Jul 4, 2020
Merged

Add failing test for autocomplete with dynamic type #721

merged 2 commits into from
Jul 4, 2020

Commits on Jun 30, 2020

  1. Add failing test for autocomplete with dynamic type 

    This will cause axe to throw an error like:

> TypeError: Cannot read property 'replace' of null

I believe that the problem might be related to getLiteralPropValue
returning `null` instead of `undefined` for dynamic props.
    @lencioni
    lencioni committed Jun 30, 2020
    Configuration menu
    Copy the full SHA
    00bd6d8 View commit details
    Browse the repository at this point in the history

  2. [Fix] autocomplete-valid: workaround for axe not being able to hand… 

    …le `null`
    @ljharb
    ljharb committed Jun 30, 2020
    Configuration menu
    Copy the full SHA
    2c47f0a View commit details
    Browse the repository at this point in the history