-
-
Notifications
You must be signed in to change notification settings - Fork 635
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Remove no-onchange from recommended and strict #757
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Before landing this, I'd like to understand which browsers it's relevant for, so we can note it in the documentation.
QuirksMode to the rescue!
So it looks like the bug was there until at least IE10 pr2. @ljharb does that address the question of compatibility? |
Also interesting to note is that it was actually written into the DOM spec a long time ago this way: https://bugzilla.mozilla.org/show_bug.cgi?id=969068#c2 |
Gotcha, thanks. At the very least, let's add that to the docs - IE 10 is still something many sites have to support, but it's reasonable to take it out of the configs. |
@ljharb What do you think about my new changes? Is this good to get merged? |
Thanks for the review and merge @ljharb ! |
The community seems to prefer to not use this rule anymore: jsx-eslint/eslint-plugin-jsx-a11y#757
TODO
See #398 (comment)
Closes #398