Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix Flow warnings #785

Merged
merged 1 commit into from
Apr 6, 2021
Merged

Fix Flow warnings #785

merged 1 commit into from
Apr 6, 2021

Conversation

jessebeach
Copy link
Collaborator

We had numerous Flow type warnings in the repo which were making PRs hard to review. This cleans up all the warnings.

@codecov
Copy link

codecov bot commented Apr 6, 2021

Codecov Report

Merging #785 (80da3d0) into master (ecec8e4) will increase coverage by 0.00%.
The diff coverage is 100.00%.

❗ Current head 80da3d0 differs from pull request most recent head 426d4c2. Consider uploading reports for the commit 426d4c2 to get more accurate results
Impacted file tree graph

@@           Coverage Diff           @@
##           master     #785   +/-   ##
=======================================
  Coverage   99.24%   99.24%           
=======================================
  Files          98       98           
  Lines        1452     1453    +1     
  Branches      477      477           
=======================================
+ Hits         1441     1442    +1     
  Misses         11       11           
Impacted Files Coverage Δ
__tests__/__util__/ruleOptionsMapperFactory.js 100.00% <100.00%> (ø)
src/rules/anchor-is-valid.js 100.00% <100.00%> (ø)
src/rules/control-has-associated-label.js 100.00% <100.00%> (ø)
src/rules/interactive-supports-focus.js 97.05% <100.00%> (ø)
src/rules/label-has-associated-control.js 93.18% <100.00%> (ø)
src/rules/media-has-caption.js 100.00% <100.00%> (ø)
...s/no-interactive-element-to-noninteractive-role.js 100.00% <100.00%> (ø)
...rc/rules/no-noninteractive-element-interactions.js 100.00% <100.00%> (ø)
...s/no-noninteractive-element-to-interactive-role.js 100.00% <100.00%> (ø)
src/rules/no-noninteractive-tabindex.js 96.77% <100.00%> (ø)
... and 3 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update ecec8e4...426d4c2. Read the comment docs.

@ljharb ljharb merged commit 426d4c2 into master Apr 6, 2021
@ljharb ljharb deleted the fix-flow branch April 6, 2021 03:23
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants