-
-
Notifications
You must be signed in to change notification settings - Fork 635
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[Tests] use @babel/eslint-parser
instead of babel-eslint
#811
[Tests] use @babel/eslint-parser
instead of babel-eslint
#811
Conversation
Codecov Report
@@ Coverage Diff @@
## master #811 +/- ##
=======================================
Coverage 99.24% 99.24%
=======================================
Files 98 98
Lines 1453 1453
Branches 477 477
=======================================
Hits 1442 1442
Misses 11 11 Continue to review full report at Codecov.
|
Anything blocking this from getting merged? |
Only a review from @ljharb |
@babel/eslint-parser
instead of babel-eslint
@babel/eslint-parser
instead of babel-eslint
also, the word "chore" is very inaccurate; chores are burdensome and changes like this are helpful. |
@ljharb Did you want the commit to be renamed to |
nah, conventional commits are garbage :-) i just haven't gotten back to it since the last update. |
8b21917
to
1cdeb11
Compare
I think because the parser added an |
1cdeb11
to
f2a3950
Compare
476d5f8
to
aed7a20
Compare
k, turns out all versions of babel's eslint parser have a peer dep on eslint 7, which has an engines that doesn't include node 11, so that's the issue here. alternatively we could stop testing eslint 7 on node 11, which i'll probably just do in a followup commit. |
🎉 |
babel-eslint
is deprecated in favor of@babel/eslint-parser
https://babeljs.io/blog/2020/07/13/the-state-of-babel-eslint