add export default instead of module.exports
#861
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
add `export default` instead of `module.exports` to avoid `Cannot use import declarations in modules that export using CommonJS` errors
Codecov Report
@@ Coverage Diff @@
## main #861 +/- ##
=======================================
Coverage 99.25% 99.25%
=======================================
Files 98 98
Lines 1474 1474
Branches 482 482
=======================================
Hits 1463 1463
Misses 11 11 Continue to review full report at Codecov.
|
|
(this was missed in #819) |
ljharb
force-pushed
the
update-boilerplate
branch
from
80f8176
to
832cbd6
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
add
export defaultinstead ofmodule.exportsin the boilerplate forrule.jsto avoidCannot use import declarations in modules that export using CommonJSerrors as mentioned in the issue #772