Merge pull request #456 from jkimbo/false-positive-jsx-key-rule

Fix false positive in jsx-key
jsx-eslint · Feb 21, 2016 · 3b56239 · 3b56239
2 parents c392099 + 0d2d162
commit 3b56239
Show file tree

Hide file tree

Showing 2 changed files with 6 additions and 1 deletion.
diff --git a/lib/rules/jsx-key.js b/lib/rules/jsx-key.js
@@ -52,6 +52,10 @@ module.exports = function(context) {
 
     // Array.prototype.map
     CallExpression: function (node) {
+      if (node.callee && node.callee.type !== 'MemberExpression') {
+        return;
+      }
+
       if (node.callee && node.callee.property && node.callee.property.name !== 'map') {
         return;
       }

diff --git a/tests/lib/rules/jsx-key.js b/tests/lib/rules/jsx-key.js
@@ -34,7 +34,8 @@ ruleTester.run('jsx-key', rule, {
     {code: '[1, 2, 3].map(x => { return <App key={x} /> });', parserOptions: parserOptions},
     {code: '[1, 2, 3].foo(x => <App />);', parserOptions: parserOptions},
     {code: 'var App = () => <div />;', parserOptions: parserOptions},
-    {code: '[1, 2, 3].map(function(x) { return; });', parserOptions: parserOptions}
+    {code: '[1, 2, 3].map(function(x) { return; });', parserOptions: parserOptions},
+    {code: 'foo(() => <div />);', parserOptions: parserOptions}
   ],
   invalid: [
     {code: '[<App />];',